ECMWFCode4Earth / vAirify

code repository for 2024 Code for Earth project #16
http://136.156.139.13
MIT License
4 stars 1 forks source link

[Failing Test] - `forecast_calibration_test.py` - Beijing o3 #340

Closed mwalker-scottlogic closed 2 months ago

mwalker-scottlogic commented 2 months ago

Running the backend regression tests yesterday and this morning, I picked up a test failure in forecast_calibration_test.py.

The test compares the forecast data on the ftp server for a specific base time to the forecast data stored in the database for the same base time and checks there isn't a divergence of more than 3%.

The test failure is specifically for Beijing, and for the pollutant o3

Image

Ben-EJ commented 2 months ago

Image Image It would seem that the number from the FTP has been rounded and because the numbers are so small this is causing a massive differential causing the error.

mwalker-scottlogic commented 2 months ago

PR raised to amend test to round to 3dp