ECMWFCode4Earth / vAirify

code repository for 2024 Code for Earth project #16
0 stars 0 forks source link

Add summary table to main screen #86

Closed amehta-scottlogic closed 2 weeks ago

amehta-scottlogic commented 3 weeks ago

Changes

This PR adds a summary table showing a comparison between forecast and in situ pollutants for the closest base and valid times

Some back end changes were required. Where these are anything other than linting I've left comments explaining

https://github.com/ECMWFCode4Earth/vAirify/assets/110030119/c15beaaa-e39b-4635-b598-f2f2189880da

github-actions[bot] commented 3 weeks ago

Coverage report for air-quality-ui

St.:grey_question:
Category Percentage Covered / Total
🟒 Statements
97.41% (-2.59% πŸ”»)
113/116
🟒 Branches
92.86% (-7.14% πŸ”»)
26/28
🟒 Functions
89.29% (-10.71% πŸ”»)
25/28
🟒 Lines
97.17% (-2.83% πŸ”»)
103/106
Show new covered files 🐣 |
St.:grey_question:
| File | Statements | Branches | Functions | Lines | | :---------------------------------------------------------------------------------------------------------------------------------------: | :--------------------------------------------------------------------------------------------------- | :--------- | :------- | :-------- | :----- | | 🟒 |
`...` / forecast-time-service.ts
| 100% | 85.71% | 100% | 100% | | 🟒 |
`...` / measurement-data-service.ts
| 100% | 100% | 100% | 100% | | 🟒 |
`...` / summary-data-mapper.ts
| 100% | 100% | 100% | 100% | | 🟒 |
`...` / mock-type-creator.ts
| 100% | 100% | 100% | 100% | | 🟒 |
`...` / forecast-data-service.ts
| 100% | 100% | 100% | 100% | | 🟒 |
`...` / GlobalSummary.tsx
| 85.71% | 100% | 25% | 85.71% | | 🟒 |
`...` / GlobalSummaryTable.tsx
| 100% | 100% | 100% | 100% | | 🟒 |
`...` / LocationCellRenderer.tsx
| 100% | 100% | 100% | 100% | | 🟒 | models.ts | 100% | 100% | 100% | 100% |

Test suite run success

30 tests passing in 8 suites.

Report generated by πŸ§ͺjest coverage report action from 442a73c6fda65bd43a304286ec56af2b7284d3f4

github-actions[bot] commented 3 weeks ago

β˜‚οΈ Python Coverage

current status: βœ…

Overall Coverage

Lines Covered Coverage Threshold Status
690 648 94% 80% 🟒

New Files

No new covered files...

Modified Files

File Coverage Status
air-quality-backend/src/air_quality/api/forecast_controller.py 100% 🟒
air-quality-backend/src/air_quality/api/main.py 100% 🟒
air-quality-backend/src/air_quality/database/in_situ.py 97% 🟒
air-quality-backend/src/air_quality/etl/forecast/forecast_dao.py 100% 🟒
air-quality-backend/src/air_quality/etl/in_situ/openaq_adapter.py 98% 🟒
air-quality-backend/src/air_quality/etl/in_situ/openaq_orchestrator.py 100% 🟒
TOTAL 99% 🟒

updated for commit: 442a73c by action🐍