search

ECNG3006-Team-B-est / PulseOximeter

0 stars 0 forks source link

the pwm does not work as intended #1

Open bhuanguwi opened 1 year ago

bhuanguwi commented 1 year ago

does not need to be in an infinite loop, thanks i will submit the fix

StephenJogie commented 1 year ago

Thanks for alerting me to this issue, I have since updated the testPWM branch to address some of the issues (see commit changes). The control signal is generated correctly and was used for our demonstration, I will commit the latest change which was done on the day of our demonstration which includes a small unit test for using the two pwm pins (one for alarm and one for control).

StephenJogie commented 1 year ago

Thanks for alerting me to this issue, I have since updated the testPWM branch to address some of the issues (see commit changes). The control signal is generated correctly and was used for our demonstration, I will commit the latest change which was done on the day of our demonstration which includes a small unit test for using the two pwm pins (one for alarm and one for control).

I forgot to mention in this reply, the current commit on the branch only has the control PWM as it is verified and tested. The alarm signal is commented out for now (this has since been fixed and the next commit will include this again).