search

ECP-CANDLE / Benchmarks

ECP-CANDLE Benchmarks
MIT License
59 stars 83 forks source link

model_name required #114

Open rajeeja opened 1 year ago

rajeeja commented 1 year ago

With the updates in candle_lib model_name is a required hyperparameter. Breaks UNO and might other Benchmarks also.

jmohdyusof commented 1 year ago

Yes, I have updated all the benchmarks to comply. Did you find an error? First line of uno_default_model.txt is model_name

rajeeja commented 1 year ago

Gotcha. Not all .txt files were changed. I was using uno_auc_model.txt in my fork. https://github.com/rajeeja/Benchmarks/tree/AUCstd1

jmohdyusof commented 1 year ago

OK, I basically just swept all the xxx_default_model.txt files, I would have missed any secondary .txt files (most benchmarks do not have more than the default_model). I can sweep the others. We also need to fix the path issue

rajeeja commented 1 year ago

Is --config_file broken?

jmohdyusof commented 1 year ago

It is because Tom wanted non-default files to be in data_dir. I am working with Cristina to fix it