ECP-CANDLE / candle_lib

MIT License
1 stars 9 forks source link

Allow ckpt module to write stats only #26

Open j-woz opened 1 year ago

j-woz commented 1 year ago

For IMPROVE results

jmohdyusof commented 1 year ago

Does this mean write stats every timestep regardless of ckpt settings? This seems to make sense to me

j-woz commented 1 year ago

The user can get that with ckpt_save_interval=1 and ckpt_save_weights_file=False

j-woz commented 1 year ago

This works as of 0fb15f7 with no application changes

jmohdyusof commented 1 year ago

What happens if I want to have the stats written and then have a usable best checkpoint? Won't ckpt_save_weights_file=False make the ckpt useless?

j-woz commented 1 year ago

That isn't supported here but I can do that next

jmohdyusof commented 1 year ago

I think the stats output should be on every timestep by default.

j-woz commented 1 year ago

Yes, I can see the use for that

jmohdyusof commented 1 year ago

I think the intent is (was?) to use this for the standard metric output. Maybe I am misremembering, but if I am correct then the stats_every_epoch makes sense