Fix BBAPI tag generation

ECP-VeloC / AXL

Asynchronous Transfer Library

MIT License

2 stars 8 forks source link

Fix BBAPI tag generation #101

Closed tonyhutter closed 3 years ago

tonyhutter commented 3 years ago

The BBAPI requires us to pass a 64-bit tag that will never be repeated on a node. Previously, we used the unix timestamp + thread ID for the tag. This lead to duplicate tags when SCR would start two checkpoints in the same second. This patch adds in an additional 2-bit quarter second field to the tag along with a quarter second wait, to ensure no identical tags are ever generated on the node.

adammoody commented 3 years ago

@tonyhutter . This looks good to me. Did you already check that it solves the problem, or are you still waiting on nodes to test?

tonyhutter commented 3 years ago

It fixes the issue - I've been unable to hit the same BB error message since applying the patch.

adammoody commented 3 years ago

Thanks, @tonyhutter