Closed tonyhutter closed 5 years ago
Looks great!
Some of the changes in the tests don't quite make sense to me, but if it works, it works.
Thanks @tonyhutter ! We can also ask IBM for a review during a call sometime. They should be able to help fill in details about the API where things aren't clear to us.
@gonsie I added the {}
brackets in my latest push
In my latest push, I changed the unique BBTAG code to be:
(unix timestamp << 32 | thread ID)
This should be fine unless the user wraps the TID in the same second. In order to do that they would have to spawn more than /proc/sys/kernel/pid_max
AXL-using threads in the same second (currently 180k+ on my development system).