Get IBM BB test working

ECP-VeloC / AXL

Asynchronous Transfer Library

MIT License

2 stars 8 forks source link

Get IBM BB test working #20

Closed tonyhutter closed 5 years ago

tonyhutter commented 5 years ago

Get IBM burst buffer test working.
Add command line arguments to test_axl.
More extensive verification of destination file after transfer.
Use the number at the end of the hostname for our "rank" that gets passed to BB_InitLibrary().
Use seconds + nanoseconds to create our unique BBTAG.
Misc cleanups
Use 4-space indents to match the rest of the files.

gonsie commented 5 years ago

Looks great!

Some of the changes in the tests don't quite make sense to me, but if it works, it works.

adammoody commented 5 years ago

Thanks @tonyhutter ! We can also ask IBM for a review during a call sometime. They should be able to help fill in details about the API where things aren't clear to us.

tonyhutter commented 5 years ago

@gonsie I added the {} brackets in my latest push

tonyhutter commented 5 years ago

In my latest push, I changed the unique BBTAG code to be:

(unix timestamp << 32 | thread ID)

This should be fine unless the user wraps the TID in the same second. In order to do that they would have to spawn more than /proc/sys/kernel/pid_max AXL-using threads in the same second (currently 180k+ on my development system).