search

ECP-VeloC / AXL

Asynchronous Transfer Library
MIT License
2 stars 8 forks source link

Fix build warnings caused by not including kvtree_util.h #24

Closed tonyhutter closed 5 years ago

tonyhutter commented 5 years ago

axl_async_bbapi.c was not including kvtree_util.h, which caused build warnings like:

[ 33%] Building C object src/CMakeFiles/axl_o.dir/axl_async_bbapi.c.o
/g/g0/hutter2/VELOC/deps/AXL.git/src/axl_async_bbapi.c: In function 'axl_async_create_bbapi':
/g/g0/hutter2/VELOC/deps/AXL.git/src/axl_async_bbapi.c:191:5: warning: implicit declaration of function 'kvtree_util_set_unsigned_long' [-Wimplicit-function-declaration]
     kvtree_util_set_unsigned_long(file_list, AXL_BBAPI_KEY_TRANSFERHANDLE, (unsigned long) thandle);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/g/g0/hutter2/VELOC/deps/AXL.git/src/axl_async_bbapi.c:192:5: warning: implicit declaration of function 'kvtree_util_set_ptr'; did you mean 'kvtree_unset_kv'? [-Wimplicit-function-declaration]
     kvtree_util_set_ptr(file_list, AXL_BBAPI_KEY_TRANSFERDEF, tdef);
     ^~~~~~~~~~~~~~~~~~~
     kvtree_unset_kv
/g/g0/hutter2/VELOC/deps/AXL.git/src/axl_async_bbapi.c: In function 'axl_async_add_bbapi':
/g/g0/hutter2/VELOC/deps/AXL.git/src/axl_async_bbapi.c:207:5: warning: implicit declaration of function 'kvtree_util_get_ptr'; did you mean 'kvtree_get_val'? [-Wimplicit-function-declaration]
     kvtree_util_get_ptr(file_list, AXL_BBAPI_KEY_TRANSFERDEF, (void**) &tdef);
     ^~~~~~~~~~~~~~~~~~~
     kvtree_get_val
/g/g0/hutter2/VELOC/deps/AXL.git/src/axl_async_bbapi.c: In function 'axl_async_start_bbapi':
/g/g0/hutter2/VELOC/deps/AXL.git/src/axl_async_bbapi.c:224:5: warning: implicit declaration of function 'kvtree_util_set_int'; did you mean 'kvtree_list_int'? [-Wimplicit-function-declaration]
     kvtree_util_set_int(file_list, AXL_KEY_STATUS, AXL_STATUS_INPROG);
     ^~~~~~~~~~~~~~~~~~~
     kvtree_list_int
/g/g0/hutter2/VELOC/deps/AXL.git/src/axl_async_bbapi.c:229:5: warning: implicit declaration of function 'kvtree_util_get_unsigned_long' [-Wimplicit-function-declaration]
     kvtree_util_get_unsigned_long(file_list, AXL_BBAPI_KEY_TRANSFERHANDLE, (unsigned long*) &thandle);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/g/g0/hutter2/VELOC/deps/AXL.git/src/axl_async_bbapi.c: In function 'axl_async_wait_bbapi':
/g/g0/hutter2/VELOC/deps/AXL.git/src/axl_async_bbapi.c:330:9: warning: implicit declaration of function 'kvtree_util_get_int'; did you mean 'kvtree_elem_key_int'? [-Wimplicit-function-declaration]
         kvtree_util_get_int(file_list, AXL_KEY_STATUS, &status);
         ^~~~~~~~~~~~~~~~~~~
         kvtree_elem_key_int
[ 40%] Building C object src/CMakeFiles/axl_o.dir/axl_err.c.o
adammoody commented 5 years ago

Thanks, @tonyhutter . Let's move this to axl_internal.h since that will likely show up in other places too.

tonyhutter commented 5 years ago

@adammoody ok, it's moved to axl_internal.h in my latest push.

adammoody commented 5 years ago

Thanks @tonyhutter