ECP-WarpX / impactx

high-performance modeling of beam dynamics in particle accelerators with collective effects
https://impactx.readthedocs.io
Other
27 stars 20 forks source link

Change distribution default parameters to Twiss in dashboard #748

Closed proy30 closed 3 weeks ago

proy30 commented 1 month ago

This PR updates the primary option for beam distribution configurations to "Twiss". The previously primary set, "Native," has been renamed to "Quadratic Form" and is now available as an alternative parameterization for users.

In addition, this PR makes minor adjustments to the code structure and docstrings within the beam distribution section. These changes do not affect functionality.

Tested with this example to ensure correct functionality.

Checklist

I noticed that all beta/emitt parameters must have non-zero values, but this validation is missing in the current PR. PR #690 includes a modified helper function with built-in validation capabilities for non-zero values. Better to either include beta/emitt validation in that PR or in a new one once #690 is merged.

Resolves #724

proy30 commented 1 month ago

Tested inputs from https://impactx.readthedocs.io/en/latest/usage/examples/distgen/README.html#a-6d-gaussian-distribution-from-twiss-functions chrome_3U0X6hV7vU Output chrome_2fLPOEBPgO

EZoni commented 1 month ago

As far as the AppleClang CI check is concerned, we probably need to rebase after #750 is merged.

proy30 commented 4 weeks ago

Updated with units chrome_Tnae78L8JK