search

ECP-copa / Cabana

Performance-portable library for particle-based simulations
Other
197 stars 51 forks source link

CI: fix typo for sanitizer build #449

Closed junghans closed 2 years ago

junghans commented 2 years ago

Continuing #412

streeve commented 2 years ago

@junghans well I broke all of this, but should I disable on fedora or add asan to fedora ci-containers?

junghans commented 2 years ago

@streeve after https://github.com/ECP-copa/ci-containers/pull/7 is merged, will it work?

streeve commented 2 years ago

@streeve after ECP-copa/ci-containers#7 is merged, will it work?

It's still not finding libasan on fedora. But more of an issue is every MPI test failing with the LeakSanitizer - any ideas?

junghans commented 2 years ago

The rawhide containers wasn't updated, let's wait until next week and then try to publish it again.

codecov[bot] commented 2 years ago

Codecov Report

Merging #449 (edc3ba7) into master (88c448b) will increase coverage by 0.1%. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #449     +/-   ##
========================================
+ Coverage    92.8%   92.9%   +0.1%     
========================================
  Files          37      37             
  Lines        4303    4444    +141     
========================================
+ Hits         3994    4130    +136     
- Misses        309     314      +5
Impacted Files Coverage Δ
cajita/src/Cajita_HypreStructuredSolver.hpp 60.5% <0.0%> (-1.5%) :arrow_down:
core/src/Cabana_Sort.hpp 100.0% <0.0%> (ø)
cajita/src/Cajita_Splines.hpp 100.0% <0.0%> (ø)
cajita/src/Cajita_Parallel.hpp 100.0% <0.0%> (ø)
cajita/src/Cajita_IndexSpace.hpp 100.0% <0.0%> (ø)
cajita/src/Cajita_Interpolation.hpp 100.0% <0.0%> (ø)
cajita/src/Cajita_GlobalGrid_impl.hpp 100.0% <0.0%> (ø)
cajita/src/Cajita_IndexConversion.hpp 100.0% <0.0%> (ø)
core/src/Cabana_CommunicationPlan.hpp 97.5% <0.0%> (+<0.1%) :arrow_up:
core/src/Cabana_VerletList.hpp 98.7% <0.0%> (+<0.1%) :arrow_up:
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 88c448b...edc3ba7. Read the comment docs.

streeve commented 2 years ago

@dalg24 can you take a quick look at this? The test for ArborX neighbor lists with a subset of particles is failing

streeve commented 2 years ago

retest this please.

streeve commented 2 years ago

@sslattery this is ready for final review - this only adds the address sanitizer and Damien pointed out my mistake for ArborX going out of bounds