ECP-copa / Cabana

Performance-portable library for particle-based simulations
Other
197 stars 51 forks source link

Add THREADS backend build to CI #537

Closed streeve closed 2 years ago

streeve commented 2 years ago

Renames backends in GHA to make this easier

streeve commented 2 years ago

Needs fix: https://github.com/kokkos/kokkos/pull/5109 Once that's merged we can run with develop only

dalg24 commented 2 years ago

How is it related to this CI build?

streeve commented 2 years ago

Our Threads failures are not just in CI, but any run with multiple threads with a parallel_reduce. @masterleinad mentioned a fix, but maybe I linked the wrong PR

dalg24 commented 2 years ago

No that would be the one you are correct But unless you have hwloc or specify the number of threads we were using only one thread

codecov[bot] commented 2 years ago

Codecov Report

Merging #537 (58d77ad) into master (a0e1690) will not change coverage. The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #537   +/-   ##
======================================
  Coverage    94.7%   94.7%           
======================================
  Files          44      44           
  Lines        5401    5401           
======================================
  Hits         5120    5120           
  Misses        281     281           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a0e1690...58d77ad. Read the comment docs.

streeve commented 2 years ago

Develop now works with my local build of core library only, but now Threads compilation fails for Cajita parallel reductions with tags

masterleinad commented 2 years ago

Develop now works with my local build of core library only, but now Threads compilation fails for Cajita parallel reductions with tags

I'll have a look.

masterleinad commented 2 years ago

https://github.com/kokkos/kokkos/pull/5123 provides a fix.

streeve commented 2 years ago

Thanks, @masterleinad