search

ECP-copa / Cabana

Performance-portable library for particle-based simulations
Other
188 stars 51 forks source link

Fix and cleanup targets and deprecations #702

Closed dalg24 closed 7 months ago

dalg24 commented 7 months ago

Configuration logs are littered with deprecation warnings (following the merge of #680)

CMake Warning (dev) at cmake/test_harness/test_harness.cmake:27 (target_link_libraries):
  The library that is being linked to, cabanacore, is marked as being
  deprecated by the owner.  The message provided by the developer is:

  NOTE: cabanacore subpackage is now Core.  Link to Cabana::Core.
  Cabana::cabanacore will be removed in a future release.

Call Stack (most recent call first):
  core/unit_test/CMakeLists.txt:49 (Cabana_add_tests_nobackend)
This warning is for project developers.  Use -Wno-dev to suppress it.

This gets rid of the issue, exports both the new targets Cabana::{Core,Grid} and the old (deprecated) ones Cabana::{cabanacore,Cajita}. The targets cabanacore and Cajita are removed since they are not exported and we don't link against them.

streeve commented 7 months ago

CI failures unrelated