search

ECP-copa / Cabana

Performance-portable library for particle-based simulations
Other
188 stars 51 forks source link

Adds linked cell parallel capability #712

Closed lebuller closed 2 weeks ago

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 95.74468% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 96.5%. Comparing base (dcaa181) to head (6525c20). Report is 59 commits behind head on master.

:exclamation: Current head 6525c20 differs from pull request most recent head 96a0bc1. Consider uploading reports for the commit 96a0bc1 to get more accurate results

Files Patch % Lines
core/src/Cabana_LinkedCellList.hpp 93.2% 5 Missing :warning:
core/src/Cabana_Parallel.hpp 97.9% 2 Missing :warning:
core/src/Cabana_NeighborList.hpp 83.3% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #712 +/- ## ======================================= Coverage 96.4% 96.5% ======================================= Files 90 92 +2 Lines 14498 14849 +351 ======================================= + Hits 13989 14332 +343 - Misses 509 517 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

streeve commented 5 months ago

Initial performance check on Frontier (with Verlet results for comparison) linkedcell verlet

Note that the results marked neighbor here are NOT exposed to the user directly (could still be done with a linear Kokkos parallel loop and direct neighbor interface usage) and the results marked iterate use the new custom neighbor_parallel_for restricted to LinkedCellLists

streeve commented 5 months ago

CI timeouts unrelated (and manually tested on HIP)

streeve commented 2 weeks ago

Final performance comparisons from Frontier - no significant changes from previous results lcl_performance_frontier verlet_performance_frontier

streeve commented 2 weeks ago

Test failures unrelated (docker, jenkins, coverage)