search

ECP-copa / Cabana

Performance-portable library for particle-based simulations
Other
188 stars 51 forks source link

Excess internal node inclusion in the BoundaryIndexSpace with Node entities #724

Closed lebuller closed 4 months ago

lebuller commented 5 months ago

A boundaryIndexSpace over Node entities includes a number of nodes on the exterior of the grid equal to the halo width as well as one additional internal node. This additional node should not be included when looping over boundaries for the purpose of setting boundary conditions.

As a sidenote, the usage and motivation for using halos in boundaryIndexSpaces and how it relates to the halo as used in sharedIndexSpaces needs to be discussed

streeve commented 5 months ago

@patrickb314 @colemanjs you've both used the boundaryIndexSpace with Node in its current form - do you have any issues with the proposed change? This is motivated to ensure consistency between internal and boundary nodes for a Poisson solve

streeve commented 4 months ago

Closing this - we instead updated our internal usage of the boundaryIndexSpace (for posterity, using a halo width zero for a Node BC exactly on the boundary and halo width one for Cell on one of the Own/Ghost side

Definitions of each boundaryIndexSpace is consistent across entities and Own/Ghost