search

ECP-copa / Cabana

Performance-portable library for particle-based simulations
Other
188 stars 51 forks source link

Fixup ArborX predicates access traits specialization #728

Closed dalg24 closed 4 months ago

dalg24 commented 4 months ago

Fix #726

The ArborX::AccessTraits specialization is too generic and yields ambiguity errors with more recent versions of ArborX.

cc @aprokop

aprokop commented 4 months ago

I just want to point out that the nightlies would still fail due to a different issue:

Cabana/Cabana/core/src/Cabana_Experimental_NeighborList.hpp:440:40:
error: 'max' is not a member of 'ArborX'
auto const max_neighbors = ArborX::max( space, counts );

as it seems that deprecations are treated as errors.

dalg24 commented 4 months ago

I just want to point out that the nightlies would still fail due to a different issue:

Cabana/Cabana/core/src/Cabana_Experimental_NeighborList.hpp:440:40:
error: 'max' is not a member of 'ArborX'
auto const max_neighbors = ArborX::max( space, counts );

as it seems that deprecations are treated as errors.

Working on a patch. Also opened arborx/arborx#1013