Implement `Impl::max_reduce` since `ArborX::max` has been deprecated

ECP-copa / Cabana

Performance-portable library for particle-based simulations

Other

188 stars 51 forks source link

Implement `Impl::max_reduce` since `ArborX::max` has been deprecated #729

Closed dalg24 closed 4 months ago

dalg24 commented 4 months ago

The ArborX::max algorithm was never intended to be public and was deprecated in arborx/ArborX#998 This PR introduces Impl::max_reduce. An alternative would be to use the Kokkos (experimental) parallel algorithms.

Loosely related to arborx/ArborX#1013

dalg24 commented 4 months ago

Addresses https://github.com/ECP-copa/Cabana/pull/728#issuecomment-1874802641

streeve commented 4 months ago

HIP and docker CI failures unrelated