search

ECP-copa / Cabana

Performance-portable library for particle-based simulations
Other
188 stars 51 forks source link

HYPRE memory fixup #733

Closed lebuller closed 4 months ago

lebuller commented 4 months ago

Removes calls to HYPRE initialize functions for vectors or matrices in setMatrixValues and solve as that leads to a memory leak. May still need more thought in how these functions are called as the way they are used by HYPRE is not the clearest/most logical.

Some leak still present in the setup function, specifically in the implementation of setupImpl. As setupImpl mainly just passes data to HYPRE, it is likely an issue on their end. This issue appears to be less significant than the issue in setMatrixValues but should still be remedied

streeve commented 4 months ago

Do you think we should merge or wait until we figure out the setup issue?

lebuller commented 4 months ago

Do you think we should merge or wait until we figure out the setup issue?

I think it may be good to go ahead and merge since this will fix a lot of the memory issue we've seen. Though we can wait to discuss on the call this afternoon