search

ECP-copa / Cabana

Performance-portable library for particle-based simulations
Other
197 stars 51 forks source link

2d neighbors #755

Open streeve opened 1 month ago

streeve commented 1 month ago

Missing 2d tests

Part of #490

streeve commented 1 month ago

Ok @lebuller this is ready for review. Looking into a good way to do the ArborX lists and planning to add 2d tests, but otherwise ready.

Also probably good to move those last two commits to a separate PR if you agree

aprokop commented 4 weeks ago

Ok @lebuller this is ready for review. Looking into a good way to do the ArborX lists and planning to add 2d tests, but otherwise ready.

What do you mean by "good way to do the ArborX lists"?

streeve commented 4 weeks ago

What do you mean by "good way to do the ArborX lists"?

Haven't tried yet, but I'd like to extract the dimension from the positions directly. Which would be nice across all cases honestly

lebuller commented 4 weeks ago

Looks mostly good to me, we should probably add tests of the 2D list capabilities as well which don't seem to be included