Closed frobnitzem closed 4 years ago
Thanks for putting time into this. I created an issue that includes your main description to track progress - #33. We can update that as we go and make this PR more specific to step 1
I've also added a PR only for the CMake target changes #32 - if you merge that in here the build should pass.
@junghans any comments on CMake style?
Accomplishes step 1 in Feature Request #33. Merges suggestions from PR #32 (thanks @streeve).
bin/CMakeLists.txt
is now particularly simple. I don't know what you want to name the library and MD executable, but cmake only allows one target to be named CabanaMD
.
@frobnitzem should be fine to update - the CMake is even simpler now
Yes, I think this one is ready. Did I miss a checkbox somewhere?
Nope, just wanted to make sure
I'm trying to create a Monte Carlo program from this, and have the following roadmap in-mind:
This is step 1. Not being a cmake expert, I don't know if
bin/CMakeLists.txt
is too verbose. I think it doesn't need Kokkos::kokkos under under target_link_libraries, but maybe some of the others are redundant too because of cmake's linking rules.