Closed streeve closed 4 years ago
Will update Travis with new Cabana flags from ECP-copa/Cabana#199 when merged
@sslattery I tried to add a check of Cabana_ENABLE_MPI
since it's required for CabanaMD, but it's blank. Am I missing something?
@sslattery I tried to add a check of
Cabana_ENABLE_MPI
since it's required for CabanaMD, but it's blank. Am I missing something?
That might not be getting added to our CMake config output. I'll take a look
So looks like we don't export that. Instead we do this in the CabanaConfig.cmake
which will get installed after a build:
include(CMakeFindDependencyMacro)
find_dependency(Kokkos REQUIRED)
if(ON)
find_dependency(MPI REQUIRED CXX)
endif()
include("${CMAKE_CURRENT_LIST_DIR}/Cabana_Targets.cmake")
Notice the if(ON)
because I have an MPI build locally. Would it help if we added that as an exported cmake variable?
Also for reference I am planning on requiring MPI in the near future.
Also for reference I am planning on requiring MPI in the near future.
Ok, in that case I won't need it. I'll rely on your checks (and inherit the MPI from Cabana?)
Ok, in that case I won't need it. I'll rely on your checks (and inherit the MPI from Cabana?)
I think that is reasonable for now. In the future you will know you always have MPI.
Update CMake and Travis to use recent Kokkos 3.0 update to CMake and Cabana CMake targets (ECP-copa/Cabana#165)