search

ECP-copa / CabanaMD

Molecular dynamics proxy application based on Cabana
Other
19 stars 13 forks source link

CMake 3.11+ required for build? #66

Closed singraber closed 3 years ago

singraber commented 3 years ago

This is only a minor issue which can probably be fixed by simply updating the documentation:

When setting up the CabanaMD build with cmake it fails with this error:

CMake Error at CMakeLists.txt:19 (include):
  include could not find load file:

    FetchContent

CMake Error at CMakeLists.txt:20 (FetchContent_Declare):
  Unknown CMake command "FetchContent_Declare".

I think the reason is a too old version of cmake: The FetchContent_Declare command appears in cmake 3.11 whereas I am currently using 3.10.2. The CabanaMD documentation says that even 3.9+ would be sufficient.

I will update my cmake and see whether this will resolve the issue...

dalg24 commented 3 years ago

You are correct. See #65

singraber commented 3 years ago

Updating cmake to 3.18.1 resolved the issue, sorry for double-posting this...

dalg24 commented 3 years ago

Updating cmake to 3.18.1 resolved the issue, sorry for double-posting this...

No need to apologize! Thanks for reporting the issue and sorry about the inconvenience. I expect the fix will be merged shortly.