search

ECP-copa / ExaMPM

Material point method proxy application based on Cabana.
BSD 3-Clause "New" or "Revised" License
9 stars 11 forks source link

Apply clang format style from Cabana #28

Closed aetx closed 3 years ago

aetx commented 3 years ago

Just applied the clang format style from Cabana.

aetx commented 3 years ago

Done. Although when running make format I get the error error: cannot use -i when reading from stdin. Is there something else to consider than just adding the package and target to the main CMakeLists.txt? I do not get the error in Cabana.

streeve commented 3 years ago

@junghans is it finding a newer clang-format?

junghans commented 3 years ago

@junghans is it finding a newer clang-format?

Yes, any clang-format can be used, only if it is called clang-format-XX (XX>10) then is won't pick it up.

junghans commented 3 years ago

Could NOT find CLANG_FORMAT: Found unsuitable version "0.0", but required is at least "10" (found /usr/bin/clang-format) Not sure why it detected 0.0.

junghans commented 3 years ago

ping @sslattery your call!

junghans commented 3 years ago

@streeve can port 34805d03a0f317fef5ff36764f556b2661e89d25 back to Cabana as well?

junghans commented 3 years ago

@streeve git am is magic: https://github.com/ECP-copa/Cabana/pull/440