ECSHackWeek / impedance.py

A Python package for working with electrochemical impedance data
MIT License
212 stars 103 forks source link

adds B/2 term to Paasch element, fixes #251 #256

Open mdmurbach opened 1 year ago

mdmurbach commented 1 year ago

image

Looks like we're missing the final term in equation 22 from the Paasch paper. This adds in B/2 to both the element code, docstring, and tests.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4226976993


Totals Coverage Status
Change from base Build 4226528233: 0.0%
Covered Lines: 848
Relevant Lines: 848

💛 - Coveralls
BGerwe commented 1 year ago

Thanks for fixing these. I'll have time to review this and #255 in the next day or two.