ECSHackWeek / impedance.py

A Python package for working with electrochemical impedance data
MIT License
212 stars 103 forks source link

[BUG] pandas not required by the package on PyPi but is imported by impedance.py #305

Closed axnj2 closed 3 weeks ago

axnj2 commented 1 month ago

Describe the bug Pandas not installed by pip installing impedance.py

To Reproduce

pip install impedance
from impedance.models.circuits import CustomCircuit

error :

Traceback (most recent call last):
  File "/Users/ajj/programmation/EquiCircuitEIS/main.py", line 6, in <module>
    from impedance.models.circuits import CustomCircuit
  File "/Users/ajj/programmation/EquiCircuitEIS/venv/lib/python3.12/site-packages/impedance/models/circuits/__init__.py", line 2, in <module>
    from .circuits import *  # noqa: F401, F403
    ^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ajj/programmation/EquiCircuitEIS/venv/lib/python3.12/site-packages/impedance/models/circuits/circuits.py", line 3, in <module>
    from impedance.visualization import plot_altair, plot_bode, plot_nyquist
  File "/Users/ajj/programmation/EquiCircuitEIS/venv/lib/python3.12/site-packages/impedance/visualization.py", line 4, in <module>
    import pandas as pd
ModuleNotFoundError: No module named 'pandas'

Expected behavior Pandas to be installed by running pip install impedance.py and the package to be listed in the requirements in PyPi

Additional context running in Python 3.12.5 on macOS 14.5 in a venv.