Isolation Segments Not Correctly Displayed

ECSTeam / cloudfoundry-top-plugin

Cloud Foundry CF cli plugin - show top stats

Apache License 2.0

73 stars 21 forks source link

Isolation Segments Not Correctly Displayed #12

Closed r0bm3 closed 5 years ago

r0bm3 commented 6 years ago

We're seeing an issue inside of the current master branch where the isolation segments displayed for apps is the CF default "shared" segment, and not the one that is associated/applied to the ORG.

We've been able to verify this by inspecting the output of: cf curl /v2/apps/[app_guid]/stats and inspecting the "isolation_segment" value that is returned.

kkellner commented 5 years ago

The issue is that cf top was looking only at the space's assigned iso seg. If it was not set, show the "default" which cf top assumed was "shared". This is incorrect as an org can set the default for the entire org. What should occur is that if an iso seg is not defined on a space, we need to look to see if the containing org has a default iso seg assigned, if it does, then show the org's default iso seg, if not, it must be "shared".

This has been fixed in v0.9.4 of cf top.

skertz commented 4 years ago

I'm seeing the same problem in v0.9.5 where my cells are displaying "shared"