search

ECToo / cryptsync

Automatically exported from code.google.com/p/cryptsync
1 stars 0 forks source link

Bug in latest (r269) SVN revision--Does not encrypt using GPG, log says there was an error. #120

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 

I compiled the latest SVN revision using VS Express 13 on Windows 7 64, but 
when I synced, synching ended abruptly. I looked in the log file and it said 
"Failed to encrypt file" and then listed all the files.

I tried debugging and found that CCreateProcessHelper::CreateProcess in 
RunExtTool() (FolderSync.cpp, line 1207) returned 87, which means 
error_invalid_parameter.

I then took a look at changes to sktoolslib, and in rev. 145, a change was made 
to CreateProcessHelper.h:

http://code.google.com/p/sktoolslib/source/diff?spec=svn145&r=145&format=side&pa
th=/trunk/CreateProcessHelper.h

SecureZeroMemory was used instead of memset, on  
LPPROCESS_INFORMATION processInfo;
and  STARTUPINFO startupInfo;

This must have changed something that CreateProcess was expecting, and it gave 
an error message.

I changed SecureZeroMemory back to memset, recompiled and the sync worked great.

What steps will reproduce the problem?
1. Compile r269 from source and sync files with gpg option  

What is the expected output? What do you see instead?
I expected encrypted files, but I see an error in the logs instead

What version of the product are you using? On what operating system?
Windows 7 x64

Please provide any additional information below.

Original issue reported on code.google.com by splen...@gmail.com on 5 Aug 2014 at 8:25

GoogleCodeExporter commented 9 years ago 
Fixed:
https://code.google.com/p/sktoolslib/source/detail?r=151

Original comment by tortoisesvn on 7 Aug 2014 at 6:58