Server crashes when G_Damage is called on a non-client entity

ECToo / oax

Automatically exported from code.google.com/p/oax

0 stars 0 forks source link

Server crashes when G_Damage is called on a non-client entity #5

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Due to a missing NULL check on client in the spawn-protect code in G_Damage, 
any attempt to damage a non-client entity will result in the server crashing. 
This can be fixed by changing line 1193 of g_combat.c from 
"if(targ->client->spawnprotected) {" to "if(targ->client && 
targ->client->spawnprotected) {".  Attached is a patch that will do this.

Original issue reported on code.google.com by jackmcbarn@gmail.com on 19 Jul 2011 at 5:18

Attachments:

G_Damage_nonclient_crash_fix.patch

GoogleCodeExporter commented 9 years ago

[deleted comment]

GoogleCodeExporter commented 9 years ago

Thanks.

Patch applied in revision 260. 

I should probably start testing with native libraries.

Original comment by sago007 on 27 Jul 2011 at 5:53