ECToo / wp-constructor

Automatically exported from code.google.com/p/wp-constructor
0 stars 0 forks source link

DIV tags in header.php causing issues when modifying CSS #90

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Your posted solution (in faq) to make header image a link: 
#header h1 a{
    display:block;
    width:100%; /*width of logo*/
    height:180px; /*height of logo*/
    text-indent: -99999% !important; /*hide text of logo*/
}
2. This was only effective on the main home page NOT on any other pages.
3.  Culprit seems to be DIV tags in header.php:
    <?php if (is_home() || is_front_page()) { ?>
    <h1 id="name"><a href="<?php echo get_option('home'); ?>/" title="<?php
bloginfo('name'); echo " &raquo; "; bloginfo('description');?>"><?php
bloginfo('name'); ?></a></h1>
    <?php } else { ?>   
    <div id="name"><a href="<?php echo get_option('home'); ?>/" title="<?php
bloginfo('name'); echo " &raquo; "; bloginfo('description');?>"><?php
bloginfo('name'); ?></a></div>
    <?php } ?>

What version of the ... are you using?
1. Wordpress: 2.9.2
2. Constructor: 2.9.2
3. PHP: 5
4. Browser: Firefox
5. OS: XP

What URL of your blog(s)?
1. http://noonespecial.ca

Please provide any additional information below.

  If there is not a reason for differentiating h1 vs div on the home page
vs post page, then removing this would appear to be simpler and cause fewer
issues. 
<h1 id="name"><a href="<?php echo get_option('home'); ?>/" title="<?php
bloginfo('name'); echo " &raquo; "; bloginfo('description');?>"><?php
bloginfo('name'); ?></a></h1>

  If there is a reason for this, what is it and what is a better solution
for making the header image a link for all pages?  

Thanks for a great theme and keep up the good work.  (and sorry for the
blank issue submission)

Original issue reported on code.google.com by taojo...@gmail.com on 26 May 2010 at 8:04

GoogleCodeExporter commented 9 years ago
Hi, use option "hide title by CSS" on header tab

Original comment by AntonShe...@gmail.com on 26 May 2010 at 8:44

GoogleCodeExporter commented 9 years ago
FAQ is fixed

Original comment by AntonShe...@gmail.com on 26 May 2010 at 8:46

GoogleCodeExporter commented 9 years ago
Okay, thanks for the very quick reply.  I had to add the following to make the 
entire
image area a link and not just the text height of the invisible title.  Seems 
to work
great now.  Thanks again.

#header #name a {
    display:block;
    height:130px;
}

Original comment by taojo...@gmail.com on 26 May 2010 at 9:09