search

ECellNitrr / teesco-website

Apache License 2.0
2 stars 8 forks source link

group permissions UI card #13

Closed naveennvrgup closed 4 years ago

naveennvrgup commented 4 years ago

Is your feature request related to a problem? Please describe. Create group permission UI card image

Describe the solution you'd like

components/GroupDetail/GroupPermissions.js class based component which takes in: 1.permissions dict with key(permission name) value(true/false)

components/GroupDetail/GroupPermissions.stories.js

  1. Initial state
  2. initial loading state (when the permission details are not yet arrived from backend)
  3. change permission set state (on click edit we will arive here. drop down of permission_sets and save button will be present.)
  4. edge case err (if the user is not admin the backend will return "You are not authorised to edit this")
  5. change permission loading state (on hitting save after changing permissionset)
rajesh6161 commented 4 years ago

@pratik0204 Sir I want handle this issue.

naveennvrgup commented 4 years ago

This is assigned to u @rajesh6161

rajesh6161 commented 4 years ago

@naveennvrgup sir change permission set state (on click edit we will arive here. drop down of permission_sets and save button will be present.) why?? he will arrive on other page? can't he just manipulate the checkbox as it will only be clickable if he is an admin otherwise it won't be clickable anymore. and yes the edit button will also be disabled too

naveennvrgup commented 4 years ago

why?? he will arrive on other page? can't he just manipulate the checkbox as it will only be clickable if he is an admin otherwise it won't be clickable anymore. and yes the edit button will also be disabled too

  1. Some select members within the same group can have some special permissionset (like few executives of PR team can have the permissions to review proofs) .
  2. Based on this concept we only store the default permission set of that group.
  3. Admins won't be changing a few permissions but the entire permissionset.
  4. If u wish we can remove the edit button and replace it with a dropdown bar and save btn on the top of this component. what say @rajesh6161?
rajesh6161 commented 4 years ago

So I would make a different story for that solely for executives and PR team with different functionalities like dropdown. And the base will be checkbox for all admin. What do you say sir? @naveennvrgup sir

naveennvrgup commented 4 years ago

i will explain over call

rajesh6161 commented 4 years ago

UserPermissions adminPermissions loading

rajesh6161 commented 4 years ago

@naveennvrgup @pratik0204 sir still ambiguity with the dropdown please help