ECellNitrr / teesco-website

Apache License 2.0
2 stars 8 forks source link

Folder structure + storybook setup #6

Closed naveennvrgup closed 4 years ago

naveennvrgup commented 4 years ago

Fixes #2

Description

  1. folder structure added
  2. added storybook setup + addons
  3. removed husky setup (no needed for now will add testing once workflow stabilizes).
  4. going for a flat structure as much as possible
  5. react app now lies in the root directory

important points:

  1. actions and reducers folder will contain the actions and reducers respectively
  2. action types and root reducers is placed on src directly
  3. page will contain the finally assembled pages which is subdivided into auth, staff and guest
  4. components folder will contain all components in its own folders (as components is further made of sub-components.
  5. utils will contain any commonly used logic or bits of code.
  6. Since the CSS is written as the material core way of js we don't have a folder for it as of now.

Type of change

Screenshots of change:

image

Checklist:

Code/Quality Assurance

kaushik27mishra commented 4 years ago

Great Work @naveennvrgup Sir! I have gone through all the points which you have mentioned in the PR and I think it will work absolutely great! Only a minor fix! we can remove the manifest.json and robots.txt from the public directory.

naveennvrgup commented 4 years ago

Great Work @naveennvrgup Sir! I have gone through all the points which you have mentioned in the PR and I think it will work absolutely great! Only a minor fix! we can remove the manifest.json and robots.txt from the public directory. thanks. but manifest.json(sets the browser bar colors in mobile and logo for our site. heard of PWA?) and robots.txt are there for a reason.