you have a litmpet controller installed, but got now limpets

lwt-pressy commented 5 years ago

EDDI version in which issue found

[please give the full version number here, not just "latest" or "current", and also say whether you are running under Voice Attack or standalone]

V3.3.1

Steps to reproduce

[give the fullest and most reproducible steps you can]
[the more reproducible, the better our chances of fixing it]

buy limpets and launch

Expected

get no limpet warning

Observed

I get the voice message "you have a litmpet controller installed, but got now limpets"

Investigation

Tkael commented 5 years ago

More detail needed. Were you using EDDI with VoiceAttack? Did you start EDDI before or after you purchased limpets? Does this always happen or is it something that you only noticed on the last play session? Please provide a copy of cargomonitor.json and the log frile from the play session (located at %appdata%/EDDI?

lwt-pressy commented 5 years ago

I use EDDI as standalone version. EDDI is alsways started before Elite because I use a powershell script which starts first all tools (Firefoy,voiceattaock, EDDI, EDDiscovery,..) and than Elite.

It happens always even in the Version before. Up to now I always just forget to report a bug.

Perhaps is has something to do with me swapping my ships regulary. Normally starting in a ship with no limpets / cargo space and than swaping to a ship with limpet controller and buying ship (with is recognised by EDDI, at least I get the voice massages "limpets bought"). If I change than to an other ship with limpet controller I always get the message "no limpets". Even after restarting the game I get the message again, after I launch the ship.

I monitored the file cargomonitor.json, the content stays all the time the same.

{ "cargo": [], "cargocarried": 0 }

the logfile from the last test run is attached.

eddi.log

Tkael commented 5 years ago

Paging @Hoodathunk . Check the log, we're getting exceptions from the EDDI.cs updateSquadronData method. @lwt-pressy This log doesn't include any information about the cargo monitor - it appears to be either incomplete or was closed before the cargo data was written?

lwt-pressy commented 5 years ago

@Tkael - I don't now when, the cargomonitor ist written, but I exited elite 2 or 3 times during this session without closing eddi. I probably didn't close eddi before uploading the log. As it is the same timestamp starting point as currently (I continued playing). Still if I grep the file for "CargoMonitor" it still shows only 1 Line (the one at the start). But it should be clearly witten by now because I see entries from my current mining at the end (EDDI has no handler for event type 'AsteroidCracked').

eddi.log

lwt-pressy commented 5 years ago

btw - this test was done with the new version V3.3.2

Tkael commented 5 years ago

Hmm. If you clear the squadron settings on the commander tab in EDDI then restart both EDDI and Elite, does the exception we see in the log go away? If it does, is cargomonitor.json accurate after you load into the game?

lwt-pressy commented 5 years ago

cleared squadron details
closed eddi
closed elite
startet eddi
started elite

cargomonitor (file or same as above) still empty.

eddi.log from this start: eddi.log

Should the limpets also show up in the Cargo-Tab in EDDI or only in the file?

lwt-pressy commented 5 years ago

hmm, after the restart some deleted values for the commander tab is shown again. I deleted it again and now there are empty, so I do the lopp again.

I also went to the nearby station sold all my limpets and bought them again.
eddi.log

Tkael commented 5 years ago

They should be showing up in the tab and in cargomonitor.json. The log file helps me see if EDDI's throwing any errors / exceptions.

Tkael commented 5 years ago

How does cargomonitor.json look now?

lwt-pressy commented 5 years ago

The file cargomonitor.json and the tab is empty (file as above).

I don't now if it helps:

the system is a windows 10 pro all updates applied
eddiscovery has always the correct cargo list (i'm running it parallel)
even though the cargomonitor.json nevers seems to change, the file timestamp updates

btw - thanks for the greast tool. The additional infos per voice are quite helpfull while playing.

lwt-pressy commented 5 years ago

some more test:

changing to eddi as voice attack plugin makes no diffence. Still no entry in the cargo monitor
buying/selling commodities also does not show up in the cargomonitor (file and tab)
if i delete the file cargomonitor.json it is not recreated after multiple stop elite, stop eddi, start eddi, start elite rounds
so i delete all files in profile except personalities folder, edsm.json and eddi.json. Still no file cargmonitor.json. All other files are created.

Darkcyde13 commented 5 years ago

I notice you said you run VoiceAttack, but also EDDI as a standalone. EDDI won't let you run two sessions at the same time, whichever runs second will pop up and error message. I take it you have disabled the VA plug-in version?

lwt-pressy commented 5 years ago

yes I disabled voice attack plugin support completely.

Tkael commented 5 years ago

@hoodathunk it's sounding like an issue with the cargo.json parsing or cargo event? Thoughts?

Hoodathunk commented 5 years ago

Just bought a Limpet controller and 10 limpets.

Cargo.json:

{ "Name":"drones", "Name_Localised":"Limpet", "Count":10, "Stolen":0 }
 ] }

cargomonitor.json:

  "cargo": [
    {
      "edname": "Drones",
      "stolen": 0,
      "haulage": 0,
      "owned": 10,
      "other": 10,
      "need": 0,
      "total": 10,
      "price": 101,
      "category": "Non-marketable",
      "haulageData": []
    }
  ],
  "cargocarried": 10
}

And Cargo Monitor tab shows 10 limpets.

I sell the 10 limpets and all shows empty again.

Re-bought 4 and undocked, received message "You only have 4 limpets onboard, you might want to consider re-stocking"

It's working for me.

Tkael commented 5 years ago

Ok. Is there anything further we can do to help troubleshoot @lwt-pressy's issue?

StivlWrith commented 5 years ago

I make a test, reactivate Cargo Monitor (because i don't use usualy) and I made 4 of them by synthesis and i see no change in cargomonitor.json. I return in station, buy drones and various commodities and my cargomonitor.json stay the same

{
  "cargo": [],
  "cargocarried": 0
}

when i lift off i had also the message about no limpet. I try with my EDDI in french and in english, and had the same result this is my Cargo.json:

{ "timestamp":"2018-12-25T18:26:04Z", "event":"Cargo", "Vessel":"Ship", "Count":19, "Inventory":[ 
{ "Name":"bauxite", "Count":1, "Stolen":0 }, 
{ "Name":"coltan", "Count":1, "Stolen":0 }, 
{ "Name":"gold", "Name_Localised":"Or", "Count":1, "Stolen":0 }, 
{ "Name":"lepidolite", "Name_Localised":"Lépidolite", "Count":1, "Stolen":0 }, 
{ "Name":"drones", "Name_Localised":"Drone", "Count":15, "Stolen":0 }
 ] }

lwt-pressy commented 5 years ago

or can I do something to help to find the issue?

Hoodathunk commented 5 years ago

I will look at the ‘UpdateSquadronData’ issue, ASAP. Not sure how, but it’s possible it’s related.

lwt-pressy commented 5 years ago

I will be away on a congress till 31th, so I can not respond in this time.

Tkael commented 5 years ago

Likely handled with #1053, per @Hoodathunk .

EDCD / EDDI