search

EDCD / EDDI

Companion application for Elite Dangerous
Other
444 stars 81 forks source link

Inserting {event.station} in the "Docking requested" script causes a crash #1664

Closed nepomuk16321 closed 4 years ago

nepomuk16321 commented 4 years ago

EDDI version in which issue is found

EDDI v.3.5.2

VoiceAttack version in which issue is found (as applicable)

Vois Attack V1.8.2

Steps to reproduce

Edit/open the "Docking requested" script. Entering the characters "{event.station}". Execute the test. Crash

Expected

I wanted EDDI to say which station the request goes to.

Observed

EDDI crashes, no matter if as plugin from VA or stand alone.

Investigation

This text (german) works without problems: {OneOf("Andockerlaubnis erbeeten", "Kontaktiere Station", "Kontaktiere Stationspersonal", "öffne Kanal", "öffne Kanal zur Station", "Anfrage ist raus", "Aye {F('Honorific')}")}

Hoodathunk commented 4 years ago

Confirmed. Only occurs when testing script in speech responder window.

Committed a hotfix for next update.

nepomuk16321 commented 4 years ago

Thanks guys, you're great!

Tkael commented 4 years ago

We should keep this open until @Hoodathunk submits his PR and it is merged. 😉

nepomuk16321 commented 4 years ago

Sorry, my bad, wrong button pressed .

Tkael commented 4 years ago

Nothing to apologize for.

richardbuckle commented 4 years ago

Hey, @Hoodathunk, is that hotfix/1664-docking-request-exception ? I think you forgot to create the PR.

richardbuckle commented 4 years ago

Fixed by #1673.