search

EDCD / EDDI

Companion application for Elite Dangerous
Other
453 stars 82 forks source link

New signals for Signal detected script #2377

Closed Darkcyde13 closed 2 years ago

Darkcyde13 commented 2 years ago

What's Wrong (please be as specific as possible)

Expected

Signals reported by the Signal detected script to be spoken as per their name.

Observed

New TG warzone signals are being reported with their type attached to the name (the whole signal name is reported).

Steps to reproduce

  1. Go to HIP 22460
  2. Do a 'honk'
  3. Listen to the various signals detected

Configuration

My Investigation

Investigation Notes

I just jumped into HIP 22460 to see whats happening with the Azimuth Saga, and when I did the honk, I got a report of lots of TG warzones that EDDI didn't handle properly.

I got this report:

AX Conflict Zone [High Intensity] detected. AX Conflict Zone [Medium Intensity] detected. FNS Bombardier $Warzone_TG_Low; detected. FNS Varian Scott $Warzone_TG_High; detected. FNS Fortitude $Warzone_TG_Med; detected. AX Conflict Zone detected. AX Conflict Zone [Low Intensity] detected. Overlook detected. AX Conflict Zone detected. INV Paramount $Warzone_TG_Low; detected. INV Audacious Dream $Warzone_TG_Med; detected. Oath of Tyndareus $Warzone_TG_Med; detected. INV Illustrious Fortune $Warzone_TG_High; detected.

As you can see, there are new Thargoid Warzones around capital ships, and EDDI obviously doesn't know about them, so it's not stripping out the '$WarzoneTG...' part.

EDDI Logs

N/A

Player journals

The corresponding Journal entries:

{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"$Warzone_TG_High:#index=1;", "SignalName_Localised":"AX Conflict Zone [High Intensity]" }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"$Warzone_TG_High:#index=1;", "SignalName_Localised":"AX Conflict Zone [High Intensity]" }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"$Warzone_TG_Med:#index=1;", "SignalName_Localised":"AX Conflict Zone [Medium Intensity]" }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"$Warzone_TG_Med:#index=2;", "SignalName_Localised":"AX Conflict Zone [Medium Intensity]" }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"INV Paramount $Warzone_TG_Low;" }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"FNS Bombardier $Warzone_TG_Low;" }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"FNS Fortitude $Warzone_TG_Med;" }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"FNS Varian Scott $Warzone_TG_High;" }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"$Warzone_TG:#index=1;", "SignalName_Localised":"AX Conflict Zone" }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"$Warzone_TG_Low:#index=1;", "SignalName_Localised":"AX Conflict Zone [Low Intensity]" }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"$Warzone_TG:#index=1;", "SignalName_Localised":"AX Conflict Zone" }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"$Warzone_TG_High:#index=1;", "SignalName_Localised":"AX Conflict Zone [High Intensity]" }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"$Warzone_TG_Med:#index=1;", "SignalName_Localised":"AX Conflict Zone [Medium Intensity]" }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"Overlook" }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"Bright Sentinel", "IsStation":true }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"$Warzone_TG_Med:#index=1;", "SignalName_Localised":"AX Conflict Zone [Medium Intensity]" }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"$Warzone_TG_Med:#index=2;", "SignalName_Localised":"AX Conflict Zone [Medium Intensity]" }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"$Warzone_TG_Med:#index=1;", "SignalName_Localised":"AX Conflict Zone [Medium Intensity]" }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"INV Audacious Dream $Warzone_TG_Med;" }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"Oath of Tyndareus $Warzone_TG_Med;" }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"$Warzone_TG_High:#index=1;", "SignalName_Localised":"AX Conflict Zone [High Intensity]" }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"$Warzone_TG_High:#index=1;", "SignalName_Localised":"AX Conflict Zone [High Intensity]" }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"$Warzone_TG_High:#index=1;", "SignalName_Localised":"AX Conflict Zone [High Intensity]" }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"$Warzone_TG_Low:#index=1;", "SignalName_Localised":"AX Conflict Zone [Low Intensity]" }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"Heart of Taurus", "IsStation":true }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"$Warzone_TG_Med:#index=1;", "SignalName_Localised":"AX Conflict Zone [Medium Intensity]" }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"$Warzone_TG:#index=1;", "SignalName_Localised":"AX Conflict Zone" }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"$Warzone_TG_Med:#index=1;", "SignalName_Localised":"AX Conflict Zone [Medium Intensity]" }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"INV Illustrious Fortune $Warzone_TG_High;" }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"$Warzone_TG_Med:#index=1;", "SignalName_Localised":"AX Conflict Zone [Medium Intensity]" }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"$Warzone_TG_High:#index=1;", "SignalName_Localised":"AX Conflict Zone [High Intensity]" }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"$Warzone_TG_Low:#index=1;", "SignalName_Localised":"AX Conflict Zone [Low Intensity]" }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSSignalDiscovered", "SystemAddress":319715002691, "SignalName":"$Warzone_TG_Med:#index=1;", "SignalName_Localised":"AX Conflict Zone [Medium Intensity]" }
{ "timestamp":"2022-08-04T23:36:28Z", "event":"FSSDiscoveryScan", "Progress":1.000000, "BodyCount":67, "NonBodyCount":42, "SystemName":"HIP 22460", "SystemAddress":319715002691 }
Tkael commented 2 years ago

Noted. It's too bad that FDev omitted localized names for those combat zones around the capitol ships (if they had, EDDI would have fallen back on the localized names).