EDCD / EDDI

Companion application for Elite Dangerous
Other
453 stars 82 forks source link

Adjust maximum system search radius #2412

Closed boyestrous closed 2 years ago

boyestrous commented 2 years ago

For the sphere-systems endpoint, EDSM won't accept a max radius higher than 100LY. It doesn't return an exception, it just returns an empty result.

Examples:

The cube-systems endpoint works differently. It has a maximum size of 200LY, doesn't include a minRadius factor, and still returns a result if you request more than the maximum. However, the results for any request over 200LY will simply be truncated to the 200LY size.

For example, the following two queries return identical results.

I changed the defaults and added checks to consistently handle calls to these functions and return the (truncated) result. I also checked other references and tests and none of them explicitly call either of these functions with maxRadius or cubeRadius values over 200.

Tkael commented 2 years ago

Looks good, thank you.