search

EDCD / EDDI

Companion application for Elite Dangerous
Other
445 stars 81 forks source link

"Flight assist" script incorrectly handles some UI interactions while in supercruise #2496

Closed slippycheeze closed 1 year ago

slippycheeze commented 1 year ago

What's Wrong (please be as specific as possible)

Expected

EDDI runs the script when I manually change flight assist; it stays silent when it automatically enables (eg: entering supercruise kinda turns it on, but only because it is in state 3 of the boolean, "in supercruise").

Observed (and steps to reproduce)

  1. GOOD: EDDI announces "flight assist disabled" when I manually turn it off, as it should.
  2. BAD: EDDI announces "flight assist enabled" when I enter supercruise, even though (a) it will be off when I return to normal space, and (b) I didn't change the state.
  3. BAD: EDDI announces "flight assist disabled" when I open various UI controls:
    • the system map
    • the galaxy map
    • the main menu
  4. BAD: EDDI announces "flight assist disabled" when I return to normal space (exit supercruise), even though it was off before I started supercruise.

Configuration

My Investigation

EDDI Logs

I enabled "verbose" logging, because I'm pretty sure you want all those debug details to figure this one out. Hope that isn't an inconvenience. I did trim the log to exclusively the section where my "test it behaves the way I think" sequence from "observed" happened, so you should only have those events.

Pretty sure it includes the journal content, too, so I figure you don't need a second copy.

eddi-flight-assist-bug.zip

Tkael commented 1 year ago

I respectfully disagree. It's technically correct to say that flight assist is enabled during supercruise and disabled again when you re-enter normal space and I don't think it really makes sense to change this behavior when you should already be able to modify your script (by checking the values of other status properties like status.fsd_status) to filter out speech in particular cases like these where you'd prefer not to hear speech.