Tkael
commented
1 year ago Since the Scan events are written immediately after the NavBeaconScan event, a test triggered by a NavBeaconScan would not yet have incorporated the Scan event data and your results likely reflect just the data which is available from EDSM. EDSM does not provide any data about whether a body is already discovered or already mapped (though we can infer that bodies from EDSM have already been discovered at least).
Testing using a system I've visited many times and have previously fully scanned:
{set reportSystem to SystemDetails("Diaguandri")}
{for body in reportSystem.bodies:
{body.name} - {if body.alreadydiscovered: "true" |else: "false"} - {if body.alreadymapped: "true" |else: "false"}
}Diaguandri A - true - false
Diaguandri B - true - false
Diaguandri C - true - false
Diaguandri B 1 - true - false
Diaguandri B 2 - true - false
Diaguandri AB 1 - true - false
Diaguandri AB 2 - true - false
Diaguandri AB 3 - true - false
Diaguandri C 1 - true - false
Diaguandri C 2 - true - false
Diaguandri C 3 - true - false
Diaguandri C 4 - true - false
Darkcyde13
What's Wrong (please be as specific as possible)
Expected
The
alreadymappedproperty of bodies to be true or false after a system scan or nav beacon scan.Observed
Stars have the property set to false, but for other bodies it is always void.
Steps to reproduce
alreadymappedproperty is false for stars, but always void for planets and moons.Configuration
My Investigation
Investigation Notes
I was looking over the 'Bodies to map' script after our discussion in #2490 and wanted to test out the suggested fix using
body.alreadymapped. However, no matter what I tried, I couldn't get things working as I expected. Upon further investigation, I have discovered that thealreadymappedproperty for planets and moons never seems to be populated, and is always void.I added this line at the top of the
{for body in reportSystem.bodies:loop:{body.name} - {dump(body.alreadydiscovered)} - {dump(body.alreadymapped)},After scanning a nav beacon of a system I'd never been to before, running the test resulted in:
I had a quick look for a system that I needed to use the FSS, but can't find one in my immediate vicinity.
I also tried manually setting
reportSystemto systems I know I've fully scanned and mapped some bodies, but I get the same result.So, it seems that the property is never populated, at least not from a honk and nav beacon scan anyway.
I notice from the player Journal that all of the bodies have the
WasDiscoveredproperty set to false, but I'm assuming this is probably because it is an already known system to the Pilots Federation.EDDI Logs
My log of the session (but before I logged out): eddi.zip
Player journals
Journal entry for the nav beacon scan: