search

EDCD / EDDI

Companion application for Elite Dangerous
Other
444 stars 81 forks source link

Always announces all mappable planets scanned #2576

Closed Ricochetv1 closed 1 year ago

Ricochetv1 commented 1 year ago

When doing surface mapping of planets, after every planet, it announces that all worthwhile planets have been mapped, even if that is not the case. It would be much more useful for it to say which other planets are worthy, and it would be nice to be able to set a threshhold in the options for what it considers worthwhile.

Darkcyde13 commented 1 year ago

Are you using a modified version of the 'Bodies to map' script? Because the default should already do what you are asking.

There is a setting at the top of the script for a minimum value threshold highValueThreshold where any body exceeding this value will be reported.

The script also filters bodies that you have already mapped, and so should not report them once you have mapped them, even if they exceed the set threshold value.

Ricochetv1 commented 1 year ago

I haven't modified anything. I'll check out the script for that threshold.

On Fri, Aug 25, 2023, 8:28 AM Darkcyde @.***> wrote:

Are you using a modified version of the 'Bodies to map' script? Because the default should already do what you are asking.

There is a setting at the top of the script for a minimum value threshold highValueThreshold where any body exceeding this value will be reported.

The script also filters bodies that you have already mapped, and so should not report them once you have mapped them, even if they exceed the set threshold value.

— Reply to this email directly, view it on GitHub https://github.com/EDCD/EDDI/issues/2576#issuecomment-1693362432, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBS4ZJPT5QQ4PISDKDNBLLXXCR6BANCNFSM6AAAAAA356LPUY . You are receiving this because you authored the thread.Message ID: @.***>

Tkael commented 1 year ago

There's also the question of whether you want bodies in fully explored and populated systems to be reported (which is another preference). Closing as presumed resolved for the time being.