EDCD / EDDI

Companion application for Elite Dangerous
Other
452 stars 82 forks source link

Duplicate Dialogue for Planet Description #2633

Closed johnny2trayz closed 4 months ago

johnny2trayz commented 4 months ago

What's Wrong

Duplicate Dialogue for Planet Description

Expected

One description per planet. I understand there is a seperate description for after mapping, but there seems to be a third one that is the same as the first. It is not always an exact duplicate, but it does seem there is a second unnecessary call being done.

Observed

Planet 3 is a notable Water world with terraformable conditions and abundant liquid water. Mapping is now complete. Efficiency bonus awarded. Planet 3 is a medium-gravity terraformable Water world. Planet 3 is a notable Water world with potential for terraforming and abundant liquid water.

Planet A 4 is notable, with potential for terraforming. Mapping is now complete. Efficiency bonus granted. Planet A 4 is a low-gravity terraformable High metal content world. Planet A 4 is notable, with terraformable conditions.

Steps to reproduce

Scanning worlds.

Configuration

My Investigation

Investigation Notes

None

EDDI Logs

https://pastebin.com/fpseS30V

Player journals

https://pastebin.com/qzHaJa7S

Tkael commented 4 months ago

Are you using the default personality? If not, does the problem still occur after you switch to the default personality? o7

johnny2trayz commented 4 months ago

I've edited the default personality because of past issues and do not know how to restore it.

Tkael commented 4 months ago

First, is the Body mapped script edited? If so, can you share the contents of that script?

image You should be able to switch to the default personality from the Active personality dropdown on the Speech Responder tab.

johnny2trayz commented 4 months ago

It is set to default.

{ Preferences }

{set bodyReport to 2} { 0 = No body report, 1 = Summary body report, 2 = Body report } {set recommendOtherMapping to 1} { 0 or 1. If 1, recommends other bodies from the Bodies to map script }

{_ Context} {SetState('eddi_context_last_action', 'scan')} {SetState('eddi_context_last_subject', 'body')} {SetState('eddi_context_body_system', system.name)} {SetState('eddi_context_body_name', event.name)} {SetState('eddi_context_last_scan_estimated_value', event.estimatedvalue)}

{ Process the event }

{if ship.Role.edname = "Exploration" || ship.Role.edname = "Multipurpose":

{Pause(3000)}

{OneOf("Mapping", "{Occasionally(2, \"Surface\")} Map")}
{OneOf("is", "is now")}
{OneOf("complete", "finished")}.

{if event.probesused <= event.efficiencytarget:
    Efficiency bonus {OneOf("awarded", "granted")}.
}

{Pause(500)}
{if bodyReport = 2:
    {F("Body report")}
|elif bodyReport = 1:
    {F("Body report summary")}
}

{if recommendOtherMapping: 
    {Pause(1500)}
    {F("Bodies to map")}
}

}

Tkael commented 4 months ago

Ok. Please confirm if the issue repeats with the default personality?

johnny2trayz commented 4 months ago

Correct. All default now. No other personalities.

Tkael commented 4 months ago

Hi there. Please confirm if this resolved by swapping to the default personality? o7

johnny2trayz commented 4 months ago

The issue does not resolve when using default personality, same issue

Tkael commented 4 months ago

I think I found the issue. Please look to the next release for the fix.