search

EDCD / EDDI

Companion application for Elite Dangerous
Other
444 stars 81 forks source link

Crashes Voiceattack upon startup, edsm.json file problem #384

Closed AIndoria closed 6 years ago

AIndoria commented 6 years ago

EDDI version in which issue found

2.4.3 and above. It works fantastically up until 2.4.2

Steps to reproduce

  1. Run EDDI
  2. Configure everything
  3. Open VoiceAttack
  4. Crashes VA after initializing plugin process

Expected

Uh...for it to load?

Observed

Crashes with "Sending info to microsoft."

Investigation

Alright, so I narrowed it down to edsm.json file. If all other files are copied from a backup directory, it works. However, Even when I don't copy that file, and a new edsm.json is generated, EDDI still crashes. I've already reset my API key from EDSM website, and it's still a no go.

TL;DR : It still doesn't work after deleting edsm.json and re-entering the info. the new Edsm.json file still causes the crash.

AIndoria commented 6 years ago

This is what I've found in eddi.log

2018-02-23T08:05:44 VoiceAttackPlugin:setStatus [W] EDDI exception: System.NullReferenceException: Object reference not set to an instance of an object.
   at EddiVoiceAttackResponder.VoiceAttackPlugin.setShipValues(Ship ship, String prefix, Object& vaProxy)

My ship's name is "Sure blood". Is it possible that eddi is having problem reading the space? Even when I ask it to read it aloud it says "sure" and not the "blood" part.

Edit:

I still get the same error when loading EDDI via Voiceattack but this time edsm.json file is deleted, however, it loads and works.

2018-02-23T08:08:13 VoiceAttackPlugin:setStatus [W] EDDI exception: System.NullReferenceException: Object reference not set to an instance of an object.
   at EddiVoiceAttackResponder.VoiceAttackPlugin.setShipValues(Ship ship, String prefix, Object& vaProxy)
Tkael commented 6 years ago

The space in the name isn't the issue - quite a few of my ships have spaces in the names. This has been a rare issue that some users have come across for some time, but I haven't been able to replicate this issue (last attempt to fix was PR #228). Do you have a more complete log that you can share? I don't see any obvious connection between edsm.json and the EddiVoiceAttackResponder.VoiceAttackPlugin.setShipValues() function - those two really shouldn't be connected. It's likely that the EddiVoiceAttackResponder.VoiceAttackPlugin.setShipValues() error is unrelated - especially if you haven't run Elite Dangerous and EDDI doesn't yet know which ship is your current ship.

richardbuckle commented 6 years ago

@AIndoria Please could you re-test with EDDI v3.0.0-b1 and let us know whether this is still occurring?

Tkael commented 6 years ago

What's the latest on this issue? Have you been able to retest with the current beta? Do you have a more complete log that you can share for this issue?

AIndoria commented 6 years ago

Hey I'm sorry I've been out of the country but I'll update sometime tonight.

On Mar 2, 2018 14:58, "Tkael" notifications@github.com wrote:

What's the latest on this issue? Have you been able to retest with the current beta? Do you have a more complete log that you can share for this issue?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/EDCD/EDDI/issues/384#issuecomment-370064773, or mute the thread https://github.com/notifications/unsubscribe-auth/AIhNfI0807P7okhl-RuzMts_aAxYv3xIks5tacCdgaJpZM4SQglv .

Tkael commented 6 years ago

Have you had a chance to re-test?

AIndoria commented 6 years ago

Seems to be working in EDDI v3.0.0-b1. Wonder what the problem was earlier. Oh well, thanks guys. Sorry about taking so long.