EDSM flightlogs not updating ?

[JCalvertJoshua]

EDDI version in which issue found

3.0.0.0-b2 using Voiceattack

Steps to reproduce

1. Make some systemjumps and view Flightlogs in EDSM (I'm viewing it using Ipad and refreshing page)

Expected

After the jump to a system I expected the system to show in my flightlogs (it used to work like this)

Observed

The jumps are not registered in the flightlogs.

Investigation

To see if in the latest beta the VA-events were working again (which they are BTW) I made a 2 jump trip and watched if the jumps appeared in EDSM. I did this because I noticed it didn't work anymore last week. The jumps didn't appear and I had to import my journal to EDSM to make them show up.

Here they are in EDSM after importing the journal:

 Luyten's Star Lady macbeth Asp Explorer Mar 15, 2018, 8:41:48 AM 12.39 Ly 42.95 Ly

 Core Sys Sector TD-T a3-3 Lady macbeth Asp Explorer Mar 15, 2018, 8:41:03 AM 41.80 Ly 43.63 Ly
 Tarach Tor Lady macbeth Asp Explorer Mar 11, 2018, 10:03:55 AM 84.53 Ly 43.00 Ly

And here are the lines from EDDI-log at that time:

2018-03-15T07:39:22 VoiceAttackPlugin:VA_Init1 [I] Executed command ((EDDI undocked)) 2018-03-15T07:40:45 VoiceAttackPlugin:VA_Init1 [I] Executed command ((EDDI fsd engaged)) 2018-03-15T07:41:03 VoiceAttackPlugin:VA_Init1 [I] Executed command ((EDDI jumped)) 2018-03-15T07:41:03 StarMapService:sendStarMapLog [W] EDSM responded with Duplicate request 2018-03-15T07:41:30 VoiceAttackPlugin:VA_Init1 [I] Executed command ((EDDI fsd engaged)) 2018-03-15T07:41:49 StarMapService:sendStarMapLog [W] EDSM responded with Duplicate request 2018-03-15T07:41:49 VoiceAttackPlugin:VA_Init1 [I] Executed command ((EDDI jumped)) 2018-03-15T07:41:57 VoiceAttackPlugin:VA_Init1 [I] Executed command ((EDDI ship refuelled)) 2018-03-15T07:43:42 VoiceAttackPlugin:VA_Init1 [I] Executed command ((EDDI entered normal space)) 2018-03-15T07:43:49 VoiceAttackPlugin:VA_Init1 [I] Executed command ((EDDI station no fire zone entered)) 2018-03-15T07:44:13 VoiceAttackPlugin:VA_Init1 [I] Executed command ((EDDI docking requested)) 2018-03-15T07:44:15 VoiceAttackPlugin:VA_Init1 [I] Executed command ((EDDI docking granted)) 2018-03-15T07:45:16 VoiceAttackPlugin:VA_Init1 [I] Executed command ((EDDI docked)) 2018-03-15T07:52:42 VoiceAttackPlugin:VA_Exit1 [I] EDDI VoiceAttack plugin exiting 2018-03-15T07:52:42 EDDI:Stop [I] EDDI 3.0.0-b2 stopped

[Tkael]

See #396. EDSM has substantially revised their API. Reviewing and updating those protocols is on the short list for upcoming updates.

[Tkael]

In the meantime, it looks like EDSM is filtering these messages as duplicates. Did you have any other 3rd party software running that also sends flight log data too EDSM?

[JCalvertJoshua]

No other 3rd party software running at the time, just VA with HCS Singularity voicepack (with EDDI included)

[richardbuckle]

Just tested a jump and scan with EDDI dev build as the only 3rd party tool running, and it was logged correctly with EDSM.

[richardbuckle]

@JCalvertJoshua please could you do a quick test for us?

With only EDDI running under VA with HCS Singularity voicepack, no other 3rd party tools, one jump. Did it show in your EDSM flight log?

Then with EDDI running standalone, no VA, no other 3rd party tools, one jump. Did it show in your EDSM flight log?

[JCalvertJoshua]

Both jumps didn't show in the EDSM flight log. I've attached EDDI.log. eddi.log

[richardbuckle]

Smoking gun:

2018-03-15T23:31:19 StarMapService:sendData [W] EDSM responded with Duplicate request 
2018-03-15T23:31:20 StarMapService:sendCredits [W] EDSM responded with Duplicate request 
2018-03-15T23:31:20 StarMapService:sendRanks [W] EDSM responded with Duplicate request 
2018-03-15T23:32:26 StarMapService:sendStarMapLog [W] EDSM responded with Duplicate request 

There is something else running that is sending data to EDSM.

[sydtrakked]

would this happen if we're using EDMC as well?

[richardbuckle]

Yes if you are running EDMC with EDDI then EDSM will de-duplicate. If the other app is having problems then EDDI won’t be able to help.

[JCalvertJoshua]

I did some more tests with beta 3 and with EDMC active or not. The first jump with EDMC on and EDDI standalone appeared in the EDSM flight log. The second jump with EDMC on and VA active also appeared. Then I closed EDMC and the two jumps after that (VA first and then EDDI standalone) didn't appear in the flight log. The four jumps all gave the "StarMapService:sendStarMapLog [W] EDSM responded with Duplicate request " message in eddi.log.

[Tkael]

Very odd. I have yet to see that message. (Either in standalone or VoiceAttack)

[Tkael]

@JCalvertJoshua Hi, are you still having this problem? My EDSM flight logs are being updated properly...

[JCalvertJoshua]

Hi, I think the problem is still there at my end. I just finished a trip to the Crab Pulsar last week but didn't look at the eddi log for I was using EDMC and that sends my jumps to my EDSM flight logs so the trip did show up in EDSM. I looked in the EDDI.log and at the beginning it gave the same error as I posted earlier about the "Duplicate request". But then I scrolled down and noticed a whole bunch of new lines starting with VoiceAttackPlugin:setStatus [W] EDDI exception: Microsoft.CSharp.RuntimeBinder.RuntimeBinderException

These lines started appearing after I upgraded to EDDI RC1. I was using voiceattack BTW.

Just now to test it out I cleared EDDI.log and started a new one (I copied the old one in case you want it) First without VA and running EDDI standalone I made just one jump and that log is EddiSA.log. Then starting a new log and again made one jump but this time using VA and that's EddiVA.log Both jumps didn't appear in EDSM (I didn't start EDMC for this test) eddi SA.log eddiVA.log

[sbrenna]

Same problem for me, but i don't have any other tool running (updating EDSM site). Only EDDI. I've changed the API key on EDSM site and update it on EDDI only: my flightlogs aren't updated by EDDI at all. Eddi.log says: 2018-03-25T15:21:46 StarMapService:Sync [I] EDSM sync completed 2018-03-25T15:27:14 StarMapService:sendMaterials [W] EDSM responded with Duplicate request 2018-03-25T15:27:14 StarMapService:sendData [W] EDSM responded with Duplicate request 2018-03-25T15:27:15 StarMapService:sendCredits [W] EDSM responded with Duplicate request 2018-03-25T15:27:15 StarMapService:sendRanks [W] EDSM responded with Duplicate request

[chriszero]

Same here,

2018-03-17T21:49:55 StarMapService:sendStarMapLog [W] EDSM responded with Duplicate request 2018-03-17T21:50:34 DataProviderService:GetSystemData [I] Generating dummy response {"name":"Kyloaln LX-D c27-1455", "stations":[], "bodies":[]} 2018-03-17T21:50:52 StarMapService:sendStarMapLog [W] EDSM responded with Duplicate request 2018-03-17T21:51:33 DataProviderService:GetSystemData [I] Generating dummy response {"name":"Kyloaln KC-E c27-1804", "stations":[], "bodies":[]} 2018-03-17T21:51:52 StarMapService:sendStarMapLog [W] EDSM responded with Duplicate request 2018-03-17T21:52:28 DataProviderService:GetSystemData [I] Generating dummy response {"name":"Kyloaln PI-C c28-2961", "stations":[], "bodies":[]} 2018-03-17T21:52:47 StarMapService:sendStarMapLog [W] EDSM responded with Duplicate request 2018-03-17T21:53:35 DataProviderService:GetSystemData [I] Generating dummy response {"name":"Kyloaln UO-A c29-460", "stations":[], "bodies":[]} 2018-03-17T21:53:53 StarMapService:sendStarMapLog [W] EDSM responded with Duplicate request 2018-03-17T21:55:18 StarMapService:sendStarMapLog [W] EDSM responded with Duplicate request 2018-03-17T21:57:07 StarMapService:sendStarMapLog [W] EDSM responded with Duplicate request 2018-03-17T21:58:21 DataProviderService:GetSystemData [I] Generating dummy response {"name":"Scheau Flyi YE-Y d1-312", "stations":[], "bodies":[]}

[Psebcool]

What's wrong with my log ?

2018-04-03T22:07:13 StarMapService:Sync [I] Syncing with EDSM 2018-04-03T22:07:13 EDDI:eventFileHeader [I] On live 2018-04-03T22:07:13 VoiceAttackPlugin:setStatus [W] EDDI exception: Microsoft.CSharp.RuntimeBinder.RuntimeBinderException: La méthode surchargée correspondant le mieux à 'EddiVoiceAttackResponder.VoiceAttackPlugin.setBodyValues(EddiDataDefinitions.Body, string, ref object)' a des arguments non valides à CallSite.Target(Closure , CallSite , Type , Body , String , Object ) à System.Dynamic.UpdateDelegates.UpdateAndExecuteVoid4[T0,T1,T2,T3](CallSite site, T0 arg0, T1 arg1, T2 arg2, T3 arg3) à EddiVoiceAttackResponder.VoiceAttackPlugin.setStarSystemValues(StarSystem system, String prefix, Object& vaProxy) 2018-04-03T22:07:13 VoiceAttackPlugin:VA_Init1 [I] EDDI VoiceAttack plugin initialization complete 2018-04-03T22:07:13 StarMapService:Sync [I] EDSM sync completed 2018-04-03T22:07:13 VoiceAttackPlugin:setStatus [W] EDDI exception: Microsoft.CSharp.RuntimeBinder.RuntimeBinderException: La méthode surchargée correspondant le mieux à 'EddiVoiceAttackResponder.VoiceAttackPlugin.setBodyValues(EddiDataDefinitions.Body, string, ref object)' a des arguments non valides at CallSite.Target(Closure , CallSite , Type , Body , String , Object ) at EddiVoiceAttackResponder.VoiceAttackPlugin.setStarSystemValues(StarSystem system, String prefix, Object& vaProxy) 2018-04-03T22:07:13 VoiceAttackPlugin:setStatus [W] EDDI exception: Microsoft.CSharp.RuntimeBinder.RuntimeBinderException: La méthode surchargée correspondant le mieux à 'EddiVoiceAttackResponder.VoiceAttackPlugin.setBodyValues(EddiDataDefinitions.Body, string, ref object)' a des arguments non valides at CallSite.Target(Closure , CallSite , Type , Body , String , Object ) at EddiVoiceAttackResponder.VoiceAttackPlugin.setStarSystemValues(StarSystem system, String prefix, Object& vaProxy)

[Tkael]

@Psebcool That's an unrelated error having to do with certain VoiceAttack variables not being written correctly. It'll be fixed in the next release.

Regarding the original issue, I have a local branch of the code that I've updated for the changes to the EDSM API. Though I haven't been able to replicate the original issue, I believe these changes should help prevent issue. The code's in freeze right now while @richardbuckle works on a long overdue translation feature (which is definitely churning up the code base), and I'm just waiting for him to to lift the current code freeze before I finalize and submit this.

[Tkael]

PR #459 has been approved for inclusion, and I believe that PR will correct this issue.

[JCalvertJoshua]

Just did a test run with rc2 and the jumps I made appeared in the EDSM flightlog's again :-)

The "VoiceAttackPlugin:setStatus [W] EDDI exception: Microsoft...." errors in the eddi.log are still there though.

[Tkael]

If you're still seeing exceptions with setStatus, let's create a new issue for that.