Voice Messages are a mixure or Englisch / German

[lwt-pressy]

EDDI version in which issue found

3.0.1-b4 under voice attack

Steps to reproduce

running EDDI under Voice Attack on an German Windows 10 and EDDI set to English.

(I'm running it in English because all other tools and E:D is set to English)

Expected

All notification are in English.

Observed

The Voice Messages are a mixure or Englisch / German. I notice the following:

• Star names on System Arrival - instead of the expected "´dash" in the name my voice says "Strich" (German for dash)
• Commodity are still German
• The Reward Credits seems a mixure of German/English, e.g. "Tausend" in stead of "thousand".

Investigation

[any investigation you have done, regression tests against earlier versions, etc]

[richardbuckle]

Thanks for the report. Does the same thing happen if you run EDDI on its own, without Voice Attack?

[lwt-pressy]

I did a short test by reinstalling 3.0.1-b4 (i switched back to 3.0.0 in the meantime). Started voice attack without plugin support, so EDDI shouldn't be loaded and than started EDDI standalone. In this environment the star names are correct. Commodities and reward are currently not in reached. So it probably has something to do with running as voice attack plugin.

[richardbuckle]

Thank you @lwt-pressy for the test.

EDDI's reads the preferences upon launch and sets the process's locale to the user's prefererence, if any. That is the standard way to do it.

Your test results imply that when we run as a VA plugin, VA is changing the current locale for the process back to de.

Q: Does VA have any language setting? If so, setting that to English would be worth a try.

If that doesn't solve it then I shall need to call on my co-devs for help, as they use VA and I don't (we think it is good to have a mix).

[richardbuckle]

We have found an issue with the startup process when running as a VA plug-in and are evaluating a fix. We need to careful to be a good citizen within VA.

[lwt-pressy]

thx, in the meantime I use EDDI standalone as a workaround. Also other curious things, like when you jump in a system the plugin says at the end "Information Maya" and nothing more works fine in the standalone version, where it is something like "Information Maya is in boom, there might...."

[Tkael]

@richardbuckle Any further thoughts on this? Could we perhaps tackle it by instantiating calls to the ResourceManager?

[richardbuckle]

No I think we should go with your earlier suggestion

 public static void VA_Init1(dynamic vaProxy)
        {
            Logging.Info("Initialising EDDI VoiceAttack plugin");

            try
            {
                GetEddiInstance(ref vaProxy);
                App.ApplyAnyOverrideCulture();
                EDDI.Instance.Start();

[richardbuckle]

I'll try to get time to do that later today.