EDCD / EDDI

Companion application for Elite Dangerous
Other
446 stars 81 forks source link

Wing mission cargo removed twice upon completion #763

Closed rodan123 closed 6 years ago

rodan123 commented 6 years ago

EDDI version in which issue found

eddi 3.0.1 rc-3 VA

Steps to reproduce

  1. Accept wing mission to deliver cargo
  2. Obtain more of the amount of cargo (I had over double) than required to fulfill delivery mission
  3. Turn in the mission
  4. Note that the cargo report has removed 2 times the amount that was turned in to complete the mission.

Expected

Cargo report removes the correct amount of cargo, the amount that was turned in

Observed

Cargo report removes double the amount turned in.

Investigation

Seems the journal has two events when completing a wing mission. One CargoDepot event and one MissionCompleted event. Cargo monitor acts on both events removing the cargo twice.

{ "timestamp":"2018-07-28T17:02:12Z", "event":"CargoDepot", "MissionID":405634968, "UpdateType":"Deliver", "CargoType":"BasicMedicines", "CargoType_Localised":"Basic Medicines", "Count":48, "StartMarketID":0, "EndMarketID":3228845824, "ItemsCollected":0, "ItemsDelivered":48, "TotalItemsToDeliver":48, "Progress":0.000000 } { "timestamp":"2018-07-28T17:02:31Z", "event":"MissionCompleted", "Faction":"Sublime Order of van Maanen's Star", "Name":"Mission_Collect_Outbreak_name", "MissionID":405634968, "Commodity":"$BasicMedicines_Name;", "Commodity_Localised":"Basic Medicines", "Count":48, "DestinationSystem":"Tau Ceti", "DestinationStation":"Avogadro Enterprise", "Reward":176100, "FactionEffects":[ { "Faction":"Sublime Order of van Maanen's Star", "Effects":[ { "Effect":"$MISSIONUTIL_Interaction_Summary_outbreak_down;", "Effect_Localised":"With fewer reported cases of illness, $#MinorFaction; hope they have prevented a full outbreak.", "Trend":"DownGood" } ], "Influence":[ { "SystemAddress":3107509506770, "Trend":"UpGood" } ], "Reputation":"UpGood" } ] }

rodan123 commented 6 years ago

Arrgg.. Wasn't a wing mission after. Will Reopen with proper mission type