search

EDCD / EDDI

Companion application for Elite Dangerous
Other
444 stars 81 forks source link

EDDI opens multiple log files for a single session #879

Closed rodan123 closed 5 years ago

rodan123 commented 6 years ago

EDDI version in which issue found

3.1-b2 under VA

Steps to reproduce

  1. Launch EDDI
  2. Look for log file

Expected

Logging entries to be contained in eddi.log

Observed

Log entries contained in several files, eddi.log, eddi1,log, eddi2.log eddi1.log contained a single line; _2018-10-14T17:22:17 [Info] VoiceAttackPlugin:VAInit1 Initialising EDDI VoiceAttack plugin

Investigation

Commenting out Logging.incrementLogs(); in eddi.cs seems to restore normalcy.

Tkael commented 6 years ago

Separating logs from multiple sessions is an intended feature. Creating a second log separation when you use the VoiceAttack plugin is an unintended consequence that we'll have to consider. Thanks.

Tkael commented 6 years ago

We may just need to make that method conditional on the value of FromVA.

Tkael commented 6 years ago

E.g. if (!FromVA) { Logging.Incrementally(); }. If that disables log incrementing entirely for VA (I can't review the code very effectively from my phone so I'm not sure), we'll want to add log incrementing to the plugin code.