search

EDCD / EDDI

Companion application for Elite Dangerous
Other
444 stars 81 forks source link

Script "Mission faction state" #969

Closed StivlWrith closed 5 years ago

StivlWrith commented 5 years ago

EDDI version in which issue found

3.1.1

Gravity

Very, very low

There is something i don't understand in this script "Mission faction state", in line 9 there is

|elif (mission.factionstate) = "Democracy":
    {OneOf("en the name of","for")} democracy

Isn't "Democracy" more of a government type than a faction state?

same line 15 |elif (mission.factionstate) = "Industrial":

Industrial is more an economic data

Darkcyde13 commented 5 years ago

When I first made my Missions System (which this is based off), I went through all the faction state types in the game. Both Democracy and Industrial were in that list, along with things like Planet, Refinery, Skimmer, and Surface. As odd as it was, I included everything for completeness, but I didn't assign speech to them all.

Of course, this is going back about two years now, so it's quite possible these have been updated in-game and are no longer needed. The others I mentioned have been removed by the EDDI team, so it's possible these two were just missed.

StivlWrith commented 5 years ago

Yes, many changes in each versions, and it's seems sometimes that they remove or change something to return in old way one or two versions later, hard to follow for every body

Tkael commented 5 years ago

We changed the code in #890 so that mission.factionstate will only output valid states. Version 3.1.1 will never see (mission.factionstate) = "Democracy" as true. @Hoodathunk, have you got this? It looks like the Cottle script may need a bit of a polish.

Hoodathunk commented 5 years ago

Resolved by PR #1300, Commit #d4a6b54.

Tkael commented 5 years ago

Merged.