EDCD / EDDN

EDDN - Elite: Dangerous Data Network
https://eddn.edcd.io/
BSD 3-Clause "New" or "Revised" License
298 stars 59 forks source link

Send information on Trade Events - Marketbuy/sell #66

Closed Berbe closed 1 year ago

Berbe commented 7 years ago

Would it be possible to add events to the Journal schema (or create a dedicated one?) to handle market trade events (MarketBuy & MarketSell)?

More than commodities price, that would give an idea of volume exchanges and allow for some nice consequences:

Athanasius commented 4 years ago

(Yes, I know this is now almost 3 years old).

I suspect the answer is no because EDDN isn't meant to relay any personal information, and actual buying and selling of commodities is personal.

You could look into implementing it as an EDMC Plugin sending data to your own server though.

Berbe commented 4 years ago

What do you mean by "personal information"?

Athanasius commented 4 years ago

You'd be able to correlate other events by the same uploaderID (it's obscured, and the key used to do this rotates, but that doesn't stop you doing so for a few hours per ID) with them buying and selling things.

I am not saying this is a valid reason to not add this, but usually Anthor is antsy about anything that even gets close to such.

As I said, it's the sort of thing you could write an EDMC plugin for.

Tkael commented 3 years ago

I actually think that these events are pretty safe from a personal information POV. And they could provide 3rd party websites with finer resolution on market data than they have now.

We currently typically see a snapshot of the market data when a commander first visits a website but we don't know (for example) if the commander made a significant dent in the demand / supply of a particular commodity during their visit.

Berbe commented 3 years ago

I would add that if the uploader ID is not tied to the user's name and it is being regularly rotated, even if specific actions are related to a specific user, it would only be during a limited time frame. Moreover, I only target very specific events, meaning that if one user was to be stalked, it would only be through those actions. Finally, all actions made by a user could allow the same, the solution here would be to stop uploading any piece of data; there is nothing specific to the proposal, which does not particularly endanger anyone's privacy more than other pieces of information.

Uriei commented 1 year ago

I'm resurrecting this to ask about the "CommunityGoal" event, I could understand the other events that might send personal data in some instances, but this specific event is Community-wide and has zero personal data from the uploader, could this one be added at some point?

Athanasius commented 1 year ago

Is there really any information available from CommunityGoal events that isn't also available from https://api.orerve.net/2.0/website/initiatives/list?lang=en (use 'Accept: text/xml' header for a more computer-readable format) ?

I'm not sure if the current data from that endpoint has no tier information just because these CGs have/had no tiers (i.e. just a single objective).

Uriei commented 1 year ago

Oh, I didn't even know that api existed! Thank you very much!

bgol commented 1 year ago

I'm not sure if the current data from that endpoint has no tier information just because these CGs have/had no tiers (i.e. just a single objective).

Afair, Tier information is only available in the journal event if you have joined the CG.

Web-API:

{
    "id": 646,
    "title": "Medical Supplies for Alliance Starport Bombing Survivors",
    "expiry": "2021-03-25 06:00:00",
    "market_name": "Krylov Ring",
    "starsystem_name": "He Bo",
    "activityType": "tradelist",
    "target_qty": 96000000,
    "qty": 19090018,
    "objective": "Basic Medicines, Advanced Medicines",
    "news": "Medical Supplies for Alliance Starport Bombing Survivors\n\nSafeguard Interstellar requires deliveries of medicines to treat casualties from the NMLA's recent terrorist attack.\n\nCEO Noel Beaumont announced:\n\n\"Hundreds of thousands of civilians still require urgent medical attention after being evacuated from the damaged stations. Many have severe caustic burns inflicted by the corrosive enzyme payload of the explosives. We have already exhausted the majority of supplies in nearby systems.\"\n\n\"To reinforce overstretched health services, we request shipments of basic medicines and advanced medicines. These can be delivered to Krylov Ring in the He Bo system.\"\n\nSafeguard Interstellar has partnered with Perez Ring Brewery to reward pilots and distribute the medicines.\n\nIf Tier 1 is reached, the top 75% of participants will receive a permanent Alioth system permit and a Lakon Spaceways Type-6 Transporter. The ship will be delivered and stored at Krylov Ring in the He Bo system by the 26th of March 3307.\n\nThe joint initiative will run for one week. If the final target is met earlier than planned, the initiative will end immediately.\n{{top5}}",
    "bulletin": "Safeguard Interstellar requires deliveries of medicines to treat casualties from the NMLA's recent terrorist attack.\n\nCEO Noel Beaumont announced:\n\n\"Hundreds of thousands of civilians still require urgent medical attention after being evacuated from the damaged stations. Many have severe caustic burns inflicted by the corrosive enzyme payload of the explosives. We have already exhausted the majority of supplies in nearby systems.\"\n\n\"To reinforce overstretched health services, we request shipments of basic medicines and advanced medicines. These can be delivered to Krylov Ring in the He Bo system.\"\n\nSafeguard Interstellar has partnered with Perez Ring Brewery to reward pilots and distribute the medicines.\n\nIf Tier 1 is reached, the top 75% of participants will receive a permanent Alioth system permit and a Lakon Spaceways Type-6 Transporter. The ship will be delivered and stored at Krylov Ring in the He Bo system by the 26th of March 3307.\n\nThe joint initiative will run for one week. If the final target is met earlier than planned, the initiative will end immediately."
}

Journal:

{
    "CGID": 646,
    "Title": "Medical Supplies for Alliance Starport Bombing Survivors",
    "SystemName": "He Bo",
    "MarketName": "Krylov Ring",
    "Expiry": "2021-03-25T06:00:00Z",
    "IsComplete": true,
    "CurrentTotal": 23250716,
    "PlayerContribution": 0,
    "NumContributors": 6487,
    "TopTier": {
      "Name": "Tier 5",
      "Bonus": ""
    },
    "TopRankSize": 10,
    "PlayerInTopRank": false,
    "TierReached": "Tier 2",
    "PlayerPercentileBand": 100,
    "Bonus": 400000
}
Athanasius commented 1 year ago

I'm not sure if the current data from that endpoint has no tier information just because these CGs have/had no tiers (i.e. just a single objective).

Afair, Tier information is only available in the journal event if you have joined the CG.

I was referring to the output of that API endpoint I quoted above:

{
      "activityType": "tradelist",
      "bulletin": "Two ... shortly afterwards.\n",
      "expiry": "2023-02-02 07:00:00",
      "id": "765",
      "images": "NewsImageMarket",
      "market_name": "Schirra Dock",
      "news": "Enhanced AX Project: AX Missile Rack Fixed\n\nTwo leading e...megaships shortly afterwards.\n\n{{top5}}",
      "objective": "Gallium, Copper, Polymers, Advanced Catalysers, Synthetic Reagents",
      "qty": "916730",
      "starsystem_name": "Kappa Reticuli",
      "target_commodity_list": "Gallium, Copper, Polymers, Advanced Catalysers, Synthetic Reagents",
      "target_qty": "13000000",
      "title": "Development of Enhanced AX Missile Rack (Fixed)"
    }

i.e. does this only have information for whatever tier is current/last reached, or is it just that these CGs only have one tier ?

If, when there is definitely more than one tier, that API endpoint doesn't contain that information, then the Journal-sourced data might have some utility.

Looking at the Inara API docs and EDMC code relating to that, there's definitely information about tiers in the Journal events.

bgol commented 1 year ago

I updated my previous comment with two examples. There is no tier information in the web-api response, only in the journal one.

Berbe commented 1 year ago

This ticket is about trade events in general - title change revert requested

It would be better if the title was reverted to reflect the actual, original requests, with my last message having remained unanswered. It would have been better if @Uriei started a seperate thread for a seperate request, and @Athanasius to recognises subjets being different, the title not matching the new question, a split was to be requested to the new requestor.

Athanasius commented 1 year ago

If we're going down that route, then this issue gets simply closed. As I said above, sending actual MarketBuy/MarketSell events is too close to Personal Information, and thus not for EDDN.

robbyxp1 commented 1 year ago

Reverted title. So, this is a very old request, which we have rejected, as it contains personal info, so lets close.