search

EDCD / EDMarketConnector

Downloads commodity market and other station data from the game Elite: Dangerous for use with all popular online and offline trading tools.
GNU General Public License v2.0
991 stars 155 forks source link

Review CQC detection. #1030

Closed Athanasius closed 2 years ago

Athanasius commented 3 years ago

Being able to queue for CQC whilst playing the actual game, i.e. not from Main Menu beforehand, is causing some issues on EDSM.

CQC re-uses 'real' star systems. Ref: https://forums.frontier.co.uk/threads/cqc-systems.234394/

Theta Ursae Majoris Boepp SU-E d12-818 Eta Cephei Bleae Aewsy GA-Y d1-14

Check the EDMC code for CQC detection. We might want to start checking for these specific system names in, I think, Location events and then not send to EDSM (or Inara? it might have good enough code to cope with this already).

Athanasius commented 3 years ago

As part of this, we could add a new journal_entry_cqc() plugin function/endpoint for reception of journal events whilst we're in CQC.

This implementation means existing plugins don't need to worry about it, they won't have the function defined (well, shouldn't...), and any plugins attempting to do anything with the limited/broken Journal events during CQC can get access to the data.

Athanasius commented 3 years ago

they won't have the function defined (well, shouldn't...)

We need to define and document a reserved plugin function name prefix for such core extensions.