search

EDCD / EDMarketConnector

Downloads commodity market and other station data from the game Elite: Dangerous for use with all popular online and offline trading tools.
GNU General Public License v2.0
991 stars 155 forks source link

Wrong System: FSSSignalDiscovered events between StartJump and FSDJump #1100

Closed NoFoolLikeOne closed 3 years ago

NoFoolLikeOne commented 3 years ago

Please check the Known Issues in case this has already been reported.

Please also check if the issue is covered in our Troubleshooting Guide. It might be something with a known work around, or where a third party (such as EDSM) is causing logging that is harmless.

Please complete the following information:

Describe the bug We noticed that AXCZ reports were being raised for systems that did not have AX CZ.

Looking into the logs we can see the Odyssey is sending FSSSignalDiscoveredEvents in between StartJump and FSDJump I believe that EDSM does not set the systemName until it gets the FSDJump event. This means that any FSSSignalDiscovered messages are attributed to the system one is jumping from instead of the one that you are jumping to.

The SystemAddress is set in the FSS events so it is possible to check that the ID64 does not match the ID64 of the current gamestate or attribute the events to the system in The id64 in the StartJump event

To Reproduce Steps to reproduce the behavior:

  1. Go to HIP 17481
  2. Jump to Delphi
  3. See error

Expected behavior Events should be attributed to the correct system

Screenshots If applicable, add screenshots to help explain your problem.

{ "timestamp":"2021-05-20T18:41:31Z", "event":"FSDJump", "Taxi":false, "Multicrew":false, "StarSystem":"HIP 17481", "SystemAddress":113556556107, "StarPos":[-58.84375,-150.25000,-305.53125], "SystemAllegiance":"", "SystemEconomy":"$economy_None;", "SystemEconomy_Localised":"None", "SystemSecondEconomy":"$economy_None;", "SystemSecondEconomy_Localised":"None", "SystemGovernment":"$government_None;", "SystemGovernment_Localised":"None", "SystemSecurity":"$GAlAXY_MAP_INFO_state_anarchy;", "SystemSecurity_Localised":"Anarchy", "Population":0, "Body":"HIP 17481 A", "BodyID":1, "BodyType":"Star", "JumpDist":23.890, "FuelUsed":0.968960, "FuelLevel":15.031040 }
{ "timestamp":"2021-05-20T18:41:31Z", "event":"Music", "MusicTrack":"DestinationFromHyperspace" }
{ "timestamp":"2021-05-20T18:41:36Z", "event":"Music", "MusicTrack":"Supercruise" }
{ "timestamp":"2021-05-20T18:42:04Z", "event":"Music", "MusicTrack":"SystemAndSurfaceScanner" }
{ "timestamp":"2021-05-20T18:42:08Z", "event":"FSSSignalDiscovered", "SystemAddress":113556556107, "SignalName":"DRAUPNER WAVE K5Z-91H", "IsStation":true }
{ "timestamp":"2021-05-20T18:42:08Z", "event":"FSSSignalDiscovered", "SystemAddress":113556556107, "SignalName":"[WIPE]THARG MOTHERSHIP JLJ-99V", "IsStation":true }
{ "timestamp":"2021-05-20T18:42:08Z", "event":"FSSSignalDiscovered", "SystemAddress":113556556107, "SignalName":"THE GRAND KURULTAI XBM-04Y", "IsStation":true }
{ "timestamp":"2021-05-20T18:42:08Z", "event":"FSSSignalDiscovered", "SystemAddress":113556556107, "SignalName":"ALISKANDER X5B-L7N", "IsStation":true }
{ "timestamp":"2021-05-20T18:42:08Z", "event":"FSSSignalDiscovered", "SystemAddress":113556556107, "SignalName":"LAHYDRA V9T-W9G", "IsStation":true }
{ "timestamp":"2021-05-20T18:42:08Z", "event":"FSSSignalDiscovered", "SystemAddress":113556556107, "SignalName":"GUMMY BEAR ONE X3Z-G8T", "IsStation":true }
{ "timestamp":"2021-05-20T18:42:08Z", "event":"FSSSignalDiscovered", "SystemAddress":113556556107, "SignalName":"CORRUPTO QZZ-51Z", "IsStation":true }
{ "timestamp":"2021-05-20T18:42:08Z", "event":"FSSSignalDiscovered", "SystemAddress":113556556107, "SignalName":"BAZA Q6T-59V", "IsStation":true }
{ "timestamp":"2021-05-20T18:42:08Z", "event":"FSSSignalDiscovered", "SystemAddress":113556556107, "SignalName":"SAPPHIRE STAR VNW-10Z", "IsStation":true }
{ "timestamp":"2021-05-20T18:42:08Z", "event":"FSSSignalDiscovered", "SystemAddress":113556556107, "SignalName":"DIRE STRAITS Q0X-8VQ", "IsStation":true }
{ "timestamp":"2021-05-20T18:42:08Z", "event":"FSSSignalDiscovered", "SystemAddress":113556556107, "SignalName":"SZOMORU VASARNAP KHV-9XQ", "IsStation":true }
{ "timestamp":"2021-05-20T18:42:08Z", "event":"FSSSignalDiscovered", "SystemAddress":113556556107, "SignalName":"[O8GC] RAZOR CREST U0K-WVH", "IsStation":true }
{ "timestamp":"2021-05-20T18:42:08Z", "event":"FSSSignalDiscovered", "SystemAddress":113556556107, "SignalName":"KEMOSHOTA CAFE Q0Y-W2F", "IsStation":true }
{ "timestamp":"2021-05-20T18:42:08Z", "event":"FSSDiscoveryScan", "Progress":1.000000, "BodyCount":3, "NonBodyCount":65, "SystemName":"HIP 17481", "SystemAddress":113556556107 }
{ "timestamp":"2021-05-20T18:42:13Z", "event":"Music", "MusicTrack":"Supercruise" }
{ "timestamp":"2021-05-20T18:42:37Z", "event":"Friends", "Status":"Online", "Name":"The Blu Fox" }
{ "timestamp":"2021-05-20T18:42:37Z", "event":"Friends", "Status":"Online", "Name":"John Guevara" }
{ "timestamp":"2021-05-20T18:42:43Z", "event":"FuelScoop", "Scooped":0.968958, "Total":16.000000 }
{ "timestamp":"2021-05-20T18:47:01Z", "event":"ReservoirReplenished", "FuelMain":15.510000, "FuelReservoir":0.490000 }
{ "timestamp":"2021-05-20T18:48:33Z", "event":"Music", "MusicTrack":"SystemAndSurfaceScanner" }
{ "timestamp":"2021-05-20T18:48:49Z", "event":"Music", "MusicTrack":"Supercruise" }
{ "timestamp":"2021-05-20T18:49:31Z", "event":"FSDTarget", "Name":"Delphi", "SystemAddress":1900262951243, "StarClass":"F" }
{ "timestamp":"2021-05-20T18:49:37Z", "event":"Friends", "Status":"Online", "Name":"The Blu Fox" }
{ "timestamp":"2021-05-20T18:49:47Z", "event":"StartJump", "JumpType":"Hyperspace", "StarSystem":"Delphi", "SystemAddress":1900262951243, "StarClass":"F" }
{ "timestamp":"2021-05-20T18:49:52Z", "event":"Music", "MusicTrack":"NoTrack" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_TG:#index=1;", "SignalName_Localised":"AX Conflict Zone" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"[SINC] SECURITY FORCES JNB-21H", "IsStation":true }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"Donar's Oak", "IsStation":true }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_High:#index=1;", "SignalName_Localised":"Conflict Zone [High Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Med:#index=1;", "SignalName_Localised":"Conflict Zone [Medium Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_TG:#index=2;", "SignalName_Localised":"AX Conflict Zone" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"ARDUANATT V4Z-1TJ", "IsStation":true }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"Lowell Class Science Vessel HLD-667" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$MULTIPLAYER_SCENARIO14_TITLE;", "SignalName_Localised":"Resource Extraction Site" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$MULTIPLAYER_SCENARIO14_TITLE;", "SignalName_Localised":"Resource Extraction Site" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$MULTIPLAYER_SCENARIO77_TITLE;", "SignalName_Localised":"Resource Extraction Site [Low]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_TG:#index=1;", "SignalName_Localised":"AX Conflict Zone" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"Eagle Eye Six" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Med:#index=1;", "SignalName_Localised":"Conflict Zone [Medium Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Low:#index=2;", "SignalName_Localised":"Conflict Zone [Low Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_High:#index=2;", "SignalName_Localised":"Conflict Zone [High Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_TG:#index=1;", "SignalName_Localised":"AX Conflict Zone" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Low:#index=3;", "SignalName_Localised":"Conflict Zone [Low Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Low:#index=1;", "SignalName_Localised":"Conflict Zone [Low Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$ListeningPost:#index=1;", "SignalName_Localised":"Listening Post" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_High:#index=1;", "SignalName_Localised":"Conflict Zone [High Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_High:#index=3;", "SignalName_Localised":"Conflict Zone [High Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Low:#index=4;", "SignalName_Localised":"Conflict Zone [Low Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Low:#index=2;", "SignalName_Localised":"Conflict Zone [Low Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Low:#index=3;", "SignalName_Localised":"Conflict Zone [Low Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$MULTIPLAYER_SCENARIO78_TITLE;", "SignalName_Localised":"Resource Extraction Site [High]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"FLETCHER'S PARADOX K6B-GKY", "IsStation":true }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Low:#index=1;", "SignalName_Localised":"Conflict Zone [Low Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_High:#index=1;", "SignalName_Localised":"Conflict Zone [High Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Med:#index=2;", "SignalName_Localised":"Conflict Zone [Medium Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Low:#index=2;", "SignalName_Localised":"Conflict Zone [Low Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Low:#index=1;", "SignalName_Localised":"Conflict Zone [Low Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Aftermath_Large:#index=1;", "SignalName_Localised":"Distress Call" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"The Sentinel" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Med:#index=3;", "SignalName_Localised":"Conflict Zone [Medium Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Low:#index=3;", "SignalName_Localised":"Conflict Zone [Low Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Med:#index=1;", "SignalName_Localised":"Conflict Zone [Medium Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"Hercules Class Bulk Cargo Ship KPX-3397" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_High:#index=2;", "SignalName_Localised":"Conflict Zone [High Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_High:#index=1;", "SignalName_Localised":"Conflict Zone [High Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_High:#index=2;", "SignalName_Localised":"Conflict Zone [High Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_High:#index=1;", "SignalName_Localised":"Conflict Zone [High Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Low:#index=1;", "SignalName_Localised":"Conflict Zone [Low Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Med:#index=1;", "SignalName_Localised":"Conflict Zone [Medium Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Low:#index=1;", "SignalName_Localised":"Conflict Zone [Low Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Low:#index=1;", "SignalName_Localised":"Conflict Zone [Low Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_TG:#index=1;", "SignalName_Localised":"AX Conflict Zone" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"CONCILIUM ORB [HIVE]JJ VLG-W3Z", "IsStation":true }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"(AXI) CROM DEKO X3N-71M", "IsStation":true }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Med:#index=1;", "SignalName_Localised":"Conflict Zone [Medium Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"MEGASH*T X7Z-69X", "IsStation":true }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"The Oracle", "IsStation":true }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"TREE OF PAIN X3V-T9Z", "IsStation":true }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Med:#index=2;", "SignalName_Localised":"Conflict Zone [Medium Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"Banner Class Bulk Cargo Ship BTG-237" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"LEPAKKOLUOLA K0G-91W", "IsStation":true }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Low:#index=2;", "SignalName_Localised":"Conflict Zone [Low Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"Modern Digital Scientific" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Low:#index=3;", "SignalName_Localised":"Conflict Zone [Low Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Low:#index=2;", "SignalName_Localised":"Conflict Zone [Low Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Med:#index=2;", "SignalName_Localised":"Conflict Zone [Medium Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Low:#index=1;", "SignalName_Localised":"Conflict Zone [Low Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Med:#index=3;", "SignalName_Localised":"Conflict Zone [Medium Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_High:#index=1;", "SignalName_Localised":"Conflict Zone [High Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_High:#index=2;", "SignalName_Localised":"Conflict Zone [High Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_TG:#index=1;", "SignalName_Localised":"AX Conflict Zone" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Med:#index=1;", "SignalName_Localised":"Conflict Zone [Medium Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Med:#index=1;", "SignalName_Localised":"Conflict Zone [Medium Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Low:#index=1;", "SignalName_Localised":"Conflict Zone [Low Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"LABYRINTH OF NIGHT Q6Y-WTQ", "IsStation":true }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"Count" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"Gordon Class Bulk Cargo Ship SOD-7416" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"[AXI] EX ALIS PUGNAMUS Q4X-6XB", "IsStation":true }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"MAJOR WHALE [SINC] RZK-NQT", "IsStation":true }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_High:#index=1;", "SignalName_Localised":"Conflict Zone [High Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$MULTIPLAYER_SCENARIO80_TITLE;", "SignalName_Localised":"Compromised Navigation Beacon" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"PLE-840 Demeter-class Cropper" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"QUEEN OF MORGOR XLF-29X", "IsStation":true }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Low:#index=1;", "SignalName_Localised":"Conflict Zone [Low Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"Amaethon Class Agricultural Vessel HDO-638" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Low:#index=2;", "SignalName_Localised":"Conflict Zone [Low Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Low:#index=1;", "SignalName_Localised":"Conflict Zone [Low Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Low:#index=1;", "SignalName_Localised":"Conflict Zone [Low Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"O.S. THARSIS Q6X-LXH", "IsStation":true }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"PONY FARM T5K-02Z", "IsStation":true }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"KAMIKAZE-FC-1 JFT-LVV", "IsStation":true }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_TG:#index=1;", "SignalName_Localised":"AX Conflict Zone" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Med:#index=2;", "SignalName_Localised":"Conflict Zone [Medium Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_TG:#index=1;", "SignalName_Localised":"AX Conflict Zone" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Low:#index=1;", "SignalName_Localised":"Conflict Zone [Low Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Med:#index=1;", "SignalName_Localised":"Conflict Zone [Medium Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$Warzone_PointRace_Low:#index=1;", "SignalName_Localised":"Conflict Zone [Low Intensity]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"Alexandria", "IsStation":true }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"Barbaros YQ24", "IsStation":true }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$MULTIPLAYER_SCENARIO77_TITLE;", "SignalName_Localised":"Resource Extraction Site [Low]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$MULTIPLAYER_SCENARIO78_TITLE;", "SignalName_Localised":"Resource Extraction Site [High]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSSSignalDiscovered", "SystemAddress":1900262951243, "SignalName":"$MULTIPLAYER_SCENARIO79_TITLE;", "SignalName_Localised":"Resource Extraction Site [Hazardous]" }
{ "timestamp":"2021-05-20T18:50:05Z", "event":"FSDJump", "Taxi":false, "Multicrew":false, "StarSystem":"Delphi", "SystemAddress":1900262951243, "StarPos":[-63.59375,-147.40625,-319.09375], "SystemAllegiance":"Thargoid", "SystemEconomy":"$economy_HighTech;", "SystemEconomy_Localised":"High Tech", "SystemSecondEconomy":"$economy_Extraction;", "SystemSecondEconomy_Localised":"Extraction", "SystemGovernment":"$government_Dictatorship;", "SystemGovernment_Localised":"Dictatorship", "SystemSecurity":"$SYSTEM_SECURITY_low;", "SystemSecurity_Localised":"Low Security", "Population":305894, "Body":"Delphi", "BodyID":0, "BodyType":"Star", "JumpDist":14.649, "FuelUsed":0.313626, "FuelLevel":15.196374, "Factions":[ { "Name":"Anti Xeno Initiative", "FactionState":"None", "Government":"Patronage", "Influence":0.153543, "Allegiance":"Independent", "Happiness":"$Faction_HappinessBand2;", "Happiness_Localised":"Happy", "MyReputation":100.000000, "ActiveStates":[ { "State":"War" } ] }, { "Name":"I.P.S.A.L Project", "FactionState":"None", "Government":"Corporate", "Influence":0.107283, "Allegiance":"Independent", "Happiness":"$Faction_HappinessBand2;", "Happiness_Localised":"Happy", "MyReputation":38.924000, "ActiveStates":[ { "State":"CivilWar" } ] }, { "Name":"Rational Logistics", "FactionState":"None", "Government":"Corporate", "Influence":0.117126, "Allegiance":"Independent", "Happiness":"$Faction_HappinessBand2;", "Happiness_Localised":"Happy", "MyReputation":17.287500, "ActiveStates":[ { "State":"CivilWar" } ] }, { "Name":"Janus Incorporated", "FactionState":"None", "Government":"Corporate", "Influence":0.107283, "Allegiance":"Independent", "Happiness":"$Faction_HappinessBand2;", "Happiness_Localised":"Happy", "MyReputation":2.967000, "ActiveStates":[ { "State":"CivilWar" } ] }, { "Name":"Aegis Research", "FactionState":"None", "Government":"Cooperative", "Influence":0.153543, "Allegiance":"Independent", "Happiness":"$Faction_HappinessBand2;", "Happiness_Localised":"Happy", "MyReputation":98.019997, "ActiveStates":[ { "State":"War" } ] }, { "Name":"Galaxy Rangers", "FactionState":"None", "Government":"Cooperative", "Influence":0.117126, "Allegiance":"Independent", "Happiness":"$Faction_HappinessBand2;", "Happiness_Localised":"Happy", "MyReputation":0.000000, "ActiveStates":[ { "State":"CivilWar" } ] }, { "Name":"Sirius Inc", "FactionState":"None", "Government":"Democracy", "Influence":0.244094, "Allegiance":"Independent", "Happiness":"$Faction_HappinessBand2;", "Happiness_Localised":"Happy", "MyReputation":81.206398 } ], "SystemFaction":{ "Name":"Sirius Inc" }, "Conflicts":[ { "WarType":"war", "Status":"active", "Faction1":{ "Name":"Anti Xeno Initiative", "Stake":"Mendez Analytics Forum", "WonDays":0 }, "Faction2":{ "Name":"Aegis Research", "Stake":"Modern Digital Scientific", "WonDays":0 } }, { "WarType":"civilwar", "Status":"active", "Faction1":{ "Name":"I.P.S.A.L Project", "Stake":"Ranganathan Engineering Hub", "WonDays":0 }, "Faction2":{ "Name":"Janus Incorporated", "Stake":"Newton Mining Station", "WonDays":0 } }, { "WarType":"civilwar", "Status":"active", "Faction1":{ "Name":"Rational Logistics", "Stake":"Iglesias Prospecting Rigs", "WonDays":0 }, "Faction2":{ "Name":"Galaxy Rangers", "Stake":"Madida Extraction Platform", "WonDays":0 } } ] }

Additional context This should also be raised to Fdev as an issue.

Athanasius commented 3 years ago

Looking into the logs we can see the Odyssey is sending FSSSignalDiscoveredEvents in between StartJump and FSDJump I believe that EDSM does not set the systemName until it gets the FSDJump event. This means that any FSSSignalDiscovered messages are attributed to the system one is jumping from instead of the one that you are jumping to.

Did you mean EDSM there, as in it's an issue with our EDSM plugin, or did you mean EDMC and you're seeing that plugins are being passed 'wrong' state ?

Athanasius commented 3 years ago

Checking some code.

plugins/eddn.py will be blindly inserting StarSystem as per the current system into these FSSSignalDiscovered events, and, yes, in this scenario it will be incorrect. I can add a check that if SystemAddress is present already in the event and it does not match where we think we currently are then we drop the event as being bad/corrupted.

Sure, I could use that to not add the StarSystem but the EDDN journal schema requires StarSystem be in the event. To get that correct for this scenario we would have to store the details of last seen StartJump separately, clear them after an FSDJump (or possibly other scenarios) and otherwise trust that is correct. I'd much rather just not send the event given this is obviously Frontier's problem at root cause. It's that or we're going to have to change EDDN schemas to no longer require StarSystem. That would take some discussion though.

Athanasius commented 3 years ago

FSSSignalDiscovered isn't valid over EDDN, I was thinking of SAASignalsFound.

So, @NoFoolLikeOne , where is it you're seeing the 'bad' data?

Unless I'm blind, EDMC doesn't change FSSSignalDiscovered at all before it's passed to plugin journal_entry().

It's not valid over EDDN, so the augmentations in plugins/eddn.py are moot.

AnthorNet commented 3 years ago

As far as EDMS in concerned the systemAddress is always used in priority https://github.com/EDSM-NET/Journal-Events/blob/master/Event.php#L279 So it should not affect it.

Athanasius commented 3 years ago

Closing this as Anthor seems sure his code will still handle it correctly.

@NoFoolLikeOne prod me if something other than EDSM is potentially affected.

NoFoolLikeOne commented 3 years ago

Thanks, Yes I meant EDMC