Investigate disabling 'Update' button unless Journal-docked.

Athanasius commented 3 years ago

Users are pressing 'Update' because they expect it to, e.g. send new data about them to Inara. It will not, nor EDSM. The most it would do is send updated (if different from currently held data) for market, shipyard and outfitting out to EDDN and other plugins.

We also have other uses pressing Update when not docked and experiencing spurious status messages: #1208 & #1018

There are some caveats:

[ ] The File > Status information about all your owned ships only comes from the /profile endpoint. So would be unavailable if not docked during the session. We can probably just address #1188 to take care of this.
[ ] We might want a user to pull CAPI data for some diagnosis. We could leave File > Save Raw Data... able to work anyway for this purpose. But note #1168 should be addressed as well, allowing for pulling fresh data if none is yet cached.
[ ] This absolutely requires #1188 as well. Yes, I repeat myself, it's important.
[ ] Make absolutely sure that any and all functionality that relies on CAPI data continues to function properly.
[ ] Is EDMC.py still working absolutely as it did before ?

Athanasius commented 3 years ago

And note that as it is Save Raw Data... totally ignores the cooldown on auto/manual Updates. That needs to change.

Athanasius commented 3 years ago

Definitely change the Update text on the button, remembering the translation, to:

Refresh Market,
Shipyard & Outfitting

Athanasius commented 3 years ago

Obviously the changed label will need translation, so use {CR} for the line break.

Also, the Cooldown XXs should probably be split over two lines to prevent main window size jumping around.

Athanasius commented 3 years ago

We'll probably want to do a CAPI pull after we know the Cmdr has sold or bought a ship, so that the list of all owned ships is properly in sync.

norohind commented 3 years ago

Then you also should consider pulling after death in case if player didn't rebought ship. UPD: There is special journal event for it: Resurrect.

Athanasius commented 2 years ago

Then you also should consider pulling after death in case if player didn't rebought ship. UPD: There is special journal event for it: Resurrect.

Now mentioned in my central #1188 comment.

Athanasius commented 2 years ago

[ ] If 'Frontier server is lagging' is encountered then we should allow a one-time, no questions asked, press of 'Update' no matter where the player is.

Athanasius commented 2 years ago

It is true that EDMC should absolutely not allow 'Update' if the game isn't even running. The player might have played elsewhere such that the latest local Journal file isn't in sync with the in-game location, and as such any cross-check for CAPI-sourced commodity, shipyard and outfitting will be unreliable.

Although that would entirely disallow running EDMC other than on the computer the game is on....

EDCD / EDMarketConnector

Investigate disabling 'Update' button unless Journal-docked. #1225