search

EDCD / EDMarketConnector

Downloads commodity market and other station data from the game Elite: Dangerous for use with all popular online and offline trading tools.
GNU General Public License v2.0
998 stars 156 forks source link

False positive getandsend:965: 'Pleiades Sector IR-W d1-55' != 'Delphi' #1264

Open norohind opened 3 years ago

norohind commented 3 years ago

Please complete the following information:

Describe the bug EDMarketConntector throwing Error: Frontier server is lagging because according to CAPI my current system is Pleiades Sector IR-W d1-55 but according to journals I'm in Delphi, key moment is Delphi is alias for Pleiades Sector IR-W d1-55 so it literally one system.

To Reproduce Steps to reproduce the behavior:

  1. Go to Delphi system
  2. Dock to anything
  3. See frontier server is lagging message

Expected behavior EDMarketConntector consider all aliases for a system as one system.

Additional context I think EDMarketConnector can rely on system ID for it.

Athanasius commented 3 years ago
  1. Are there are other systems affected by this?
  2. Is there a list someone else already maintains ?

I think, perhaps, we should implement this as a file we host in releases to be downloaded at startup and then consulted. This would forgo the need for a new release if a new such system comes to light.

norohind commented 3 years ago

Colonia is alias for Eol Prou RS-T d3-94 Beagle Point is alias for Ceeckia ZQ-L c24-0 and I believe there are exists more are these systems also causing this bug? I don't know but it cost to check

Athanasius commented 2 years ago

Oh my, that is annoying (he says whilst filling up on commodies at The Oracle in Delphi).

Tkael commented 2 years ago

Per Discord #general chat, there may be another: 

The other nameclash is {"System": {"name": ["15 Geminorum", "14 Geminorum"]}}
Athanasius commented 2 years ago

We've had a report that the station O'Hare's Hanger/Hangar thing is fixed, and when someone from Frontier acknowledged that issue we also highlighted the system names issue in from here.

So, can anyone confirm if Delphi is now working without EDMC complaining ?

Athanasius commented 2 years ago

Robby has just run into this Delphi rename still not being recognised by CAPI. Specifically it was a fleet carrier position being reported using the procgen name instead of "Delphi".