Closed Athanasius closed 2 years ago
Checking the schema could be any of:
Looking at my own examples of codexentry
events all of them have everything but Traits
, of which I have zero examples. For all I know it somtimes looks like:
Traits: [
''
]
or
Traits: [
'foo',
''
]
It looks like this might be due to a game bug, sometimes writing ''
as the System
(name) value. CometBorne supplied a file of all their CodexEntry events, and in it I found over 8000 such instances, the latest being:
<removed>
That system is Pheia Aewsy LV-Y d11 (EDSM).
We probably want to start doing some validation of CodexEntry
data in the EDDN plugin.
Ignore all of that. I goofed a jq
filter, and set those fields to ""
, rather than testing if they already were.
Closing in favour of #1431 , under the assumption this was some older messages being replayed that were recorded under an older, buggier version of EDMC and/or the game.
NB: We added codexentry schema support in 5.2.0 - 2021-10-25.
The new EDDN logging has brought to light things like:
Presumably we're allowing through some key where the value is an empty string, whereas the schema thinks there should always be a value of at least one character. This might mean relaxing the EDDN schema, or it might mean we need to do some checks and pre-processing.